Add baichuan chat template jinjia file#2390
Merged
Conversation
Collaborator
|
for future reference, here's the thread on official Baichuan on the tokenizer format ("reverse engineered" by the community): |
simon-mo
approved these changes
Jan 9, 2024
hongxiayang
pushed a commit
to hongxiayang/vllm
that referenced
this pull request
Jan 18, 2024
hongxiayang
pushed a commit
to hongxiayang/vllm
that referenced
this pull request
Feb 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I deployed Baichuan model with command.
Ask model write a poem by OpenAI API.
The model reponse is quite strage, it seems like the model is asking and answering itself.
Through code analysis, I found that Baichuan Model wraps the conversations using a custom function and did not provide a chat_template in tokenizer, while vllm defaults to using the 'tokenizer.apply_chat_template' function for processing. So we need convert the Baichuan custom function to Jinja format, then 'tokenizer.apply_chat_template' can work as model expected.
The convered chat template jinja is as followed:
Then I saved it and tested the same case with command as followed.
Then test model with 'baichuan2-chat.jinja'. The response great!