Skip to content

[Core]: Remove V1 engine proxy as no longer required #23762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hickeyma wants to merge 5 commits into from
Closed

[Core]: Remove V1 engine proxy as no longer required #23762

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d8beca5
Remove v1 engine proxy as no longer required
hickeyma Aug 27, 2025
ca20855
Merge branch 'main' into core/remove-v1-engine-class-proxy
hickeyma Aug 27, 2025
8bfdf8c
Merge branch 'main' into core/remove-v1-engine-class-proxy
hickeyma Aug 27, 2025
558a72d
Merge branch 'main' into core/remove-v1-engine-class-proxy
hickeyma Aug 28, 2025
3ecefc7
Merge branch 'main' into core/remove-v1-engine-class-proxy
hickeyma Aug 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions vllm/engine/async_llm_engine.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1117,10 +1117,3 @@ async def collective_rpc(self,
"""
return await self.engine.collective_rpc_async(method, timeout, args,
kwargs)


# TODO(v1): Remove this class proxy when V1 goes default.
if envs.is_set("VLLM_USE_V1") and envs.VLLM_USE_V1:
from vllm.v1.engine.async_llm import AsyncLLM

AsyncLLMEngine = AsyncLLM # type: ignore
5 changes: 0 additions & 5 deletions vllm/engine/llm_engine.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1893,8 +1893,3 @@ def collective_rpc(self,
kwargs: Optional[dict[str, Any]] = None) -> list[_R]:
return self.model_executor.collective_rpc(method, timeout, args,
kwargs)


if envs.is_set("VLLM_USE_V1") and envs.VLLM_USE_V1:
from vllm.v1.engine.llm_engine import LLMEngine as V1LLMEngine
LLMEngine = V1LLMEngine # type: ignore