Repository navigation
Conversation
Signed-off-by: ApostaC <yihua98@uchicago.edu>
6 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This PR serves as a PoC of how we should use the new semantics introduced in #23620
With this "dumb PoC", we can already see the decrease in the overhead in the scheduler.
Test result
Timing the
Scheduler.schedule()function:Before this PR:
After this PR:
Nsys profile screenshot
Before this PR: 8.38 ms when scheduling the prefill requests
After this PR: 2.97 ms when scheduling the prefill requests
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.