Skip to content

Resolve PLaMo2 issue with transformers>=4.53#23520

Closed
Alnusjaponica wants to merge 3 commits intovllm-project:mainfrom
pfnet:plamo2-latest-transformers
Closed

Resolve PLaMo2 issue with transformers>=4.53#23520
Alnusjaponica wants to merge 3 commits intovllm-project:mainfrom
pfnet:plamo2-latest-transformers

Conversation

@Alnusjaponica
Copy link
Contributor

@Alnusjaponica Alnusjaponica commented Aug 25, 2025

Purpose

Resolve #22999

Test Plan

Test Result

(Optional) Documentation Update


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.

Signed-off-by: Hemmi Shinichi <shemmi@preferred.jp>
Signed-off-by: Hemmi Shinichi <shemmi@preferred.jp>
Signed-off-by: Hemmi Shinichi <shemmi@preferred.jp>
@hmellor
Copy link
Member

hmellor commented Aug 28, 2025

Hi @Alnusjaponica, does the plamo2 test pass for you locally?

@Alnusjaponica
Copy link
Contributor Author

I’ll close this PR as this change is included by #23998

@Alnusjaponica
Copy link
Contributor Author

Alnusjaponica commented Sep 2, 2025

@hmellor
Apologies for the delayed reply.
The unit tests currently depend on mamba-ssm and causal-conv1d, which is why this PR has remained a draft. #23998 primarily targets V1 engine support but partially relies on the changes here, so we’ve included the bugfix in this PR. We’d like to re-enable the unit tests as well, but it likely makes more sense to align on V1 support first and then restore the tests.
#23520 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: plamo2 broken on main using transformers==4.55.0

2 participants