Allow setting fastapi root_path argument#2341
Merged
simon-mo merged 1 commit intovllm-project:mainfrom Jan 12, 2024
Merged
Conversation
Contributor
Author
|
@zhuohan123 Would appreciate if you can review when you get time |
simon-mo
approved these changes
Jan 12, 2024
xjpang
pushed a commit
to xjpang/vllm
that referenced
this pull request
Jan 14, 2024
hongxiayang
pushed a commit
to hongxiayang/vllm
that referenced
this pull request
Jan 18, 2024
hongxiayang
pushed a commit
to hongxiayang/vllm
that referenced
this pull request
Feb 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When FastAPI is run behind a path-based proxy the swagger fails to render because it is not aware of the path the application root is on
E.g. If the app is hosted on
https://example.com/vllm-svc/thenwith
root_path=Noneit will look for openapi.json athttps://example.com/openapi.jsonand fail with 404with
root_path="vllm-svc"it will look for openapi.json athttps://example.com/vllm-svc/openapi.jsonwhich works correctlyThis change only affects the swagger at
/docsSee: https://fastapi.tiangolo.com/advanced/behind-a-proxy/#proxy-with-a-stripped-path-prefix