Add unit tests for batched guided and non-guided requests#23389
Merged
simon-mo merged 1 commit intovllm-project:mainfrom Aug 22, 2025
Merged
Add unit tests for batched guided and non-guided requests#23389simon-mo merged 1 commit intovllm-project:mainfrom
simon-mo merged 1 commit intovllm-project:mainfrom
Conversation
Signed-off-by: Yong Hoon Shin <yhshin@meta.com>
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds a valuable unit test to catch a bug related to batching guided and non-guided requests. The test case is well-structured and directly addresses the scenario described. My main feedback is a critical improvement to make the test more robust by ensuring proper resource cleanup, which will prevent potential test flakiness in the future.
mgoin
approved these changes
Aug 22, 2025
Member
mgoin
left a comment
There was a problem hiding this comment.
Looks reasonable to me, let's see if CI green. Thanks!
Collaborator
Author
|
@mgoin the newly added test passed in |
epwalsh
pushed a commit
to epwalsh/vllm
that referenced
this pull request
Aug 28, 2025
…ct#23389) Signed-off-by: Yong Hoon Shin <yhshin@meta.com>
xiao-llm
pushed a commit
to xiao-llm/vllm
that referenced
this pull request
Aug 28, 2025
…ct#23389) Signed-off-by: Yong Hoon Shin <yhshin@meta.com> Signed-off-by: Xiao Yu <xiao.yu@amd.com>
zhewenl
pushed a commit
to zhewenl/vllm
that referenced
this pull request
Aug 28, 2025
…ct#23389) Signed-off-by: Yong Hoon Shin <yhshin@meta.com>
mengxingkongzhouhan
pushed a commit
to mengxingkongzhouhan/vllm
that referenced
this pull request
Aug 30, 2025
…ct#23389) Signed-off-by: Yong Hoon Shin <yhshin@meta.com>
zhewenl
pushed a commit
to zhewenl/vllm
that referenced
this pull request
Sep 3, 2025
…ct#23389) Signed-off-by: Yong Hoon Shin <yhshin@meta.com>
FeiDaLI
pushed a commit
to FeiDaLI/vllm
that referenced
this pull request
Sep 25, 2025
…ct#23389) Signed-off-by: Yong Hoon Shin <yhshin@meta.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Context: A bug was introduced in #21862 that causes non-guided requests to output incorrect values when batched together with guided requests. See #22896 for technical details of this bug. This bug is fixed by either #22896 or #22963.
This PR adds a unit test that would've caught this bug.
Test Plan
Test Result
Trunk, test passes:
After undoing fixes in both #22896 and #22963 (outlines backend seems fine).
(Optional) Documentation Update
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.