[CI Bugfix] Fix CI by fully removing --enable-prompt-adapter#23284
[CI Bugfix] Fix CI by fully removing --enable-prompt-adapter#23284simon-mo merged 1 commit intovllm-project:mainfrom
Conversation
Signed-off-by: mgoin <mgoin64@gmail.com>
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Code Review
This pull request addresses a CI failure by removing the deprecated --enable-prompt-adapter command-line argument. The change is confined to vllm/engine/arg_utils.py and is a clean removal of a no-op argument. I have verified that there are no remaining usages of this argument within the provided codebase, making this a safe and correct change. I approve of this fix.
…oject#23284) Signed-off-by: mgoin <mgoin64@gmail.com> Signed-off-by: Duncan Moss <djm.moss@gmail.com>
…oject#23284) Signed-off-by: mgoin <mgoin64@gmail.com>
…oject#23284) Signed-off-by: mgoin <mgoin64@gmail.com> Signed-off-by: Xiao Yu <xiao.yu@amd.com>
…oject#23284) Signed-off-by: mgoin <mgoin64@gmail.com>
…oject#23284) Signed-off-by: mgoin <mgoin64@gmail.com>
…oject#23284) Signed-off-by: mgoin <mgoin64@gmail.com>
…oject#23284) Signed-off-by: mgoin <mgoin64@gmail.com>
Purpose
Fix CI failure introduced by #23190
Test Plan
Test Result
(Optional) Documentation Update
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.