Skip to content

[Misc] Support MMMU accuracy benchmark#23034

Open
tanruixiang wants to merge 5 commits intovllm-project:mainfrom
tanruixiang:support_mmmu
Open

[Misc] Support MMMU accuracy benchmark#23034
tanruixiang wants to merge 5 commits intovllm-project:mainfrom
tanruixiang:support_mmmu

Conversation

@tanruixiang
Copy link
Copy Markdown
Contributor

@tanruixiang tanruixiang commented Aug 16, 2025

Purpose

related #23033

Test Plan

Test Result

(Optional) Documentation Update


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.

@github-actions
Copy link
Copy Markdown

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the performance Performance-related issues label Aug 16, 2025
@tanruixiang tanruixiang mentioned this pull request Aug 16, 2025
4 tasks
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for the MMMU accuracy benchmark, including scripts for both HuggingFace and vLLM, along with data and evaluation utilities. My review focuses on two high-severity issues in the data processing logic: a security vulnerability due to the use of eval(), and a correctness bug related to missing image placeholders in prompts for multimodal models. Addressing these will improve the security and correctness of the benchmark.

Signed-off-by: tanruixiang <tanruixiang0104@gmail.com>
Signed-off-by: tanruixiang <tanruixiang0104@gmail.com>
Signed-off-by: tanruixiang <tanruixiang0104@gmail.com>
@tanruixiang tanruixiang marked this pull request as ready for review August 17, 2025 15:14
@DarkLight1337
Copy link
Copy Markdown
Member

Sorry for the delay. To run it in CI, perhaps you can refer to #21810

@tanruixiang
Copy link
Copy Markdown
Contributor Author

Sorry for the delay. To run it in CI, perhaps you can refer to #21810

Thank you. I'll take care of it in the next few days.

@github-actions
Copy link
Copy Markdown

This pull request has been automatically marked as stale because it has not had any activity within 90 days. It will be automatically closed if no further activity occurs within 30 days. Leave a comment if you feel this pull request should remain open. Thank you!

@github-actions github-actions bot added the stale Over 90 days of inactivity label Jan 17, 2026
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jan 17, 2026

Hi @tanruixiang, the pre-commit checks have failed. Please run:

uv pip install pre-commit
pre-commit install
pre-commit run --all-files

Then, commit the changes and push to your branch.

For future commits, pre-commit will run automatically on changed files before each commit.

Tip

Is mypy or markdownlint failing?
mypy and markdownlint are run differently in CI. If the failure is related to either of these checks, please use the following commands to run them locally:
# For mypy (substitute "3.10" with the failing version if needed)
pre-commit run --hook-stage manual mypy-3.10
# For markdownlint
pre-commit run --hook-stage manual markdownlint

@github-actions github-actions bot added unstale Recieved activity after being labelled stale and removed stale Over 90 days of inactivity labels Jan 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

performance Performance-related issues unstale Recieved activity after being labelled stale

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants