[Misc] Support MMMU accuracy benchmark#23034
[Misc] Support MMMU accuracy benchmark#23034tanruixiang wants to merge 5 commits intovllm-project:mainfrom
Conversation
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Code Review
This pull request adds support for the MMMU accuracy benchmark, including scripts for both HuggingFace and vLLM, along with data and evaluation utilities. My review focuses on two high-severity issues in the data processing logic: a security vulnerability due to the use of eval(), and a correctness bug related to missing image placeholders in prompts for multimodal models. Addressing these will improve the security and correctness of the benchmark.
Signed-off-by: tanruixiang <tanruixiang0104@gmail.com>
3deef1d to
1cf31ec
Compare
Signed-off-by: tanruixiang <tanruixiang0104@gmail.com>
Signed-off-by: tanruixiang <tanruixiang0104@gmail.com>
|
Sorry for the delay. To run it in CI, perhaps you can refer to #21810 |
Thank you. I'll take care of it in the next few days. |
|
This pull request has been automatically marked as stale because it has not had any activity within 90 days. It will be automatically closed if no further activity occurs within 30 days. Leave a comment if you feel this pull request should remain open. Thank you! |
|
Hi @tanruixiang, the pre-commit checks have failed. Please run: uv pip install pre-commit
pre-commit install
pre-commit run --all-filesThen, commit the changes and push to your branch. For future commits, Tip Is
|
Purpose
related #23033
Test Plan
Test Result
(Optional) Documentation Update
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.