-
-
Notifications
You must be signed in to change notification settings - Fork 11.3k
[Bugfix] fix cuda 12.6 and 11.8 build #22952
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bugfix] fix cuda 12.6 and 11.8 build #22952
Conversation
Signed-off-by: Jinzhen Lin <[email protected]>
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request aims to fix CUDA build issues for versions 11.8 and 12.6 by conditionally applying the -static-global-template-stub=false compile flag. The change introduces a version check before setting the flag. However, there's a potential inconsistency: the code checks for CUDA version >= 12.8, while the pull request title mentions fixing version 12.6. This could lead to the flag being incorrectly disabled for CUDA versions 12.6 and 12.7. I've added comments suggesting to align the version check with the intended fix, likely by changing 12.8 to 12.6.
Signed-off-by: Jinzhen Lin <[email protected]>
|
@mgoin Could you plz look at this PR? |
mgoin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh, sorry for making you use this flag 😓
Signed-off-by: Jinzhen Lin <[email protected]>
Signed-off-by: Jinzhen Lin <[email protected]>
Signed-off-by: Jinzhen Lin <[email protected]> Signed-off-by: Duncan Moss <[email protected]>
Signed-off-by: Jinzhen Lin <[email protected]>
Signed-off-by: Jinzhen Lin <[email protected]> Signed-off-by: Xiao Yu <[email protected]>
Signed-off-by: Jinzhen Lin <[email protected]>
fix cuda 12.6 and 11.8 build introduced by #22428