Skip to content

Conversation

@jinzhen-lin
Copy link
Contributor

fix cuda 12.6 and 11.8 build introduced by #22428

Signed-off-by: Jinzhen Lin <[email protected]>
@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the ci/build label Aug 15, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to fix CUDA build issues for versions 11.8 and 12.6 by conditionally applying the -static-global-template-stub=false compile flag. The change introduces a version check before setting the flag. However, there's a potential inconsistency: the code checks for CUDA version >= 12.8, while the pull request title mentions fixing version 12.6. This could lead to the flag being incorrectly disabled for CUDA versions 12.6 and 12.7. I've added comments suggesting to align the version check with the intended fix, likely by changing 12.8 to 12.6.

Signed-off-by: Jinzhen Lin <[email protected]>
@jeejeelee
Copy link
Collaborator

@mgoin Could you plz look at this PR?

@mgoin mgoin added bug Something isn't working ready ONLY add when PR is ready to merge/full CI is needed labels Aug 15, 2025
Copy link
Member

@mgoin mgoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh, sorry for making you use this flag 😓

@mgoin mgoin enabled auto-merge (squash) August 15, 2025 02:14
@mgoin mgoin merged commit 3e6dd40 into vllm-project:main Aug 15, 2025
73 checks passed
yiliu30 pushed a commit to yiliu30/vllm-fork that referenced this pull request Aug 19, 2025
divakar-amd pushed a commit to divakar-amd/vllm_upstream that referenced this pull request Aug 20, 2025
djmmoss pushed a commit to djmmoss/vllm that referenced this pull request Aug 21, 2025
epwalsh pushed a commit to epwalsh/vllm that referenced this pull request Aug 28, 2025
xiao-llm pushed a commit to xiao-llm/vllm that referenced this pull request Aug 28, 2025
zhewenl pushed a commit to zhewenl/vllm that referenced this pull request Aug 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working ci/build ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants