Skip to content

[Bugfix] Fix parsing of --disable-mm-preprocessor-cache #22909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 14, 2025
Merged

[Bugfix] Fix parsing of --disable-mm-preprocessor-cache #22909

merged 1 commit into from
Aug 14, 2025

Conversation

@DarkLight1337
Copy link
Member

@DarkLight1337 DarkLight1337 commented Aug 14, 2025 •
edited by github-actions bot
Loading

Purpose

FIX #22900

Test Plan

Test Result

(Optional) Documentation Update

Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.

@DarkLight1337 DarkLight1337 requested a review from Isotr0py August 14, 2025 14:49
@DarkLight1337 DarkLight1337 added the ready ONLY add when PR is ready to merge/full CI is needed label Aug 14, 2025
@DarkLight1337 DarkLight1337 mentioned this pull request Aug 14, 2025
Closed
gemini-code-assist[bot]
gemini-code-assist bot reviewed Aug 14, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly fixes a bug in the command-line argument parsing for --disable-mm-preprocessor-cache. Using type=bool with argparse is a common pitfall, as it evaluates any non-empty string to True. The change to action="store_true" ensures the flag behaves as intended, setting the value to True only when the flag is present. The fix is correct and well-contained. I have no further suggestions.

@github-actions
Copy link

github-actions bot commented Aug 14, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) August 14, 2025 15:08
@vllm-bot vllm-bot merged commit dbe2980 into vllm-project:main Aug 14, 2025
9 of 17 checks passed
@DarkLight1337 DarkLight1337 deleted the fix-arg-type branch August 14, 2025 15:09
yiliu30 pushed a commit to yiliu30/vllm-fork that referenced this pull request Aug 19, 2025
@DarkLight1337 @yiliu30
[Bugfix] Fix parsing of --disable-mm-preprocessor-cache (vllm-proje…
cc595f4 
…ct#22909)

Signed-off-by: DarkLight1337 <[email protected]>
divakar-amd pushed a commit to divakar-amd/vllm_upstream that referenced this pull request Aug 20, 2025
@DarkLight1337 @divakar-amd
[Bugfix] Fix parsing of --disable-mm-preprocessor-cache (vllm-proje…
25a3132 
…ct#22909)

Signed-off-by: DarkLight1337 <[email protected]>
djmmoss pushed a commit to djmmoss/vllm that referenced this pull request Aug 21, 2025
@DarkLight1337 @djmmoss
[Bugfix] Fix parsing of --disable-mm-preprocessor-cache (vllm-proje…
65ad494 
…ct#22909)

Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: Duncan Moss <[email protected]>
epwalsh pushed a commit to epwalsh/vllm that referenced this pull request Aug 28, 2025
@DarkLight1337 @epwalsh
[Bugfix] Fix parsing of --disable-mm-preprocessor-cache (vllm-proje…
4825e63 
…ct#22909)

Signed-off-by: DarkLight1337 <[email protected]>
xiao-llm pushed a commit to xiao-llm/vllm that referenced this pull request Aug 28, 2025
@DarkLight1337 @amd-xiaoyu12
[Bugfix] Fix parsing of --disable-mm-preprocessor-cache (vllm-proje…
82945ab 
…ct#22909)

Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: Xiao Yu <[email protected]>
zhewenl pushed a commit to zhewenl/vllm that referenced this pull request Aug 28, 2025
@DarkLight1337 @zhewenl
[Bugfix] Fix parsing of --disable-mm-preprocessor-cache (vllm-proje…
30e8cbe 
…ct#22909)

Signed-off-by: DarkLight1337 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Isotr0py Isotr0py Isotr0py approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

--disable-mm-preprocessor-cache now expects argument

3 participants

@DarkLight1337 @Isotr0py @vllm-bot