[Bugfix][CI] Fix test_remote_decode_lifecycle.py::test_short_prompt_lifecycle#22727
[Bugfix][CI] Fix test_remote_decode_lifecycle.py::test_short_prompt_lifecycle#22727vllm-bot merged 1 commit intovllm-project:mainfrom
test_remote_decode_lifecycle.py::test_short_prompt_lifecycle#22727Conversation
There was a problem hiding this comment.
Code Review
This pull request addresses a bug in test_short_prompt_lifecycle where the test was failing due to an incorrect assignment. The original code attempted to set a finished_sending attribute on a ModelRunnerOutput instance, which does not have this attribute, leading to test failure and potential memory leaks.
The fix correctly replaces this with a call to the create_model_runner_output utility function. This function properly constructs a ModelRunnerOutput object, including the nested KVConnectorOutput with the finished_sending information. This ensures that the scheduler is correctly notified about the finished KV transfer, allowing it to free the associated resources.
The change is clean, effective, and resolves the bug. The test now passes as expected.
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
|
Seems we have another test failure related to Gemma3n, let's fix that in the next PR 😅 |
…lifecycle` (vllm-project#22727) Signed-off-by: NickLucche <nlucches@redhat.com> Signed-off-by: Paul Pak <paulpak58@gmail.com>
…lifecycle` (vllm-project#22727) Signed-off-by: NickLucche <nlucches@redhat.com> Signed-off-by: Diego-Castan <diego.castan@ibm.com>
…lifecycle` (vllm-project#22727) Signed-off-by: NickLucche <nlucches@redhat.com>
…lifecycle` (vllm-project#22727) Signed-off-by: NickLucche <nlucches@redhat.com>
…lifecycle` (vllm-project#22727) Signed-off-by: NickLucche <nlucches@redhat.com> Signed-off-by: Xiao Yu <xiao.yu@amd.com>
…lifecycle` (vllm-project#22727) Signed-off-by: NickLucche <nlucches@redhat.com>
This test is failing on main, preventing clean merges. With this PR it fails no more
Test introduced in #21074.