Skip to content

[Bugfix][CI] Fix test_remote_decode_lifecycle.py::test_short_prompt_lifecycle#22727

Merged
vllm-bot merged 1 commit intovllm-project:mainfrom
NickLucche:pd-fix-test
Aug 12, 2025
Merged

[Bugfix][CI] Fix test_remote_decode_lifecycle.py::test_short_prompt_lifecycle#22727
vllm-bot merged 1 commit intovllm-project:mainfrom
NickLucche:pd-fix-test

Conversation

@NickLucche
Copy link
Collaborator

@NickLucche NickLucche commented Aug 12, 2025

This test is failing on main, preventing clean merges. With this PR it fails no more

(llmd) ➜  vllm git:(78077d541) ✗ glog | head -n 1                                                                                         
* 78077d541 (HEAD, upstream/main) Move `SchedulerConfig` from `config/__init__.py` to `config/scheduler.py` (#22626)
(llmd) ➜  vllm git:(78077d541) ✗ p -m pytest -q --tb=no tests/v1/kv_connector/unit/test_remote_decode_lifecycle.py::test_short_prompt_lifecycle 

F                                                                                                                                                              [100%]
====================================================================== short test summary info =======================================================================
FAILED tests/v1/kv_connector/unit/test_remote_decode_lifecycle.py::test_short_prompt_lifecycle - AssertionError
1 failed in 10.59s
(llmd) ➜  vllm git:(78077d541) ✗ 
(llmd) ➜  vllm git:(78077d541) ✗ gsw pd-fix-test 
Previous HEAD position was 78077d541 Move `SchedulerConfig` from `config/__init__.py` to `config/scheduler.py` (#22626)
Switched to branch 'pd-fix-test'
(llmd) ➜  vllm git:(pd-fix-test) ✗ p -m pytest -q --tb=no       tests/v1/kv_connector/unit/test_remote_decode_lifecycle.py::test_short_prompt_lifecycle
.                                                                                                                                                              [100%]
1 passed in 10.94s

Test introduced in #21074.

Signed-off-by: NickLucche <nlucches@redhat.com>
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses a bug in test_short_prompt_lifecycle where the test was failing due to an incorrect assignment. The original code attempted to set a finished_sending attribute on a ModelRunnerOutput instance, which does not have this attribute, leading to test failure and potential memory leaks.

The fix correctly replaces this with a call to the create_model_runner_output utility function. This function properly constructs a ModelRunnerOutput object, including the nested KVConnectorOutput with the finished_sending information. This ensures that the scheduler is correctly notified about the finished KV transfer, allowing it to free the associated resources.

The change is clean, effective, and resolves the bug. The test now passes as expected.

@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) August 12, 2025 12:38
@DarkLight1337 DarkLight1337 added the ready ONLY add when PR is ready to merge/full CI is needed label Aug 12, 2025
@DarkLight1337
Copy link
Member

Seems we have another test failure related to Gemma3n, let's fix that in the next PR 😅

@vllm-bot vllm-bot merged commit 3d9d40e into vllm-project:main Aug 12, 2025
26 of 30 checks passed
paulpak58 pushed a commit to paulpak58/vllm that referenced this pull request Aug 13, 2025
…lifecycle` (vllm-project#22727)

Signed-off-by: NickLucche <nlucches@redhat.com>
Signed-off-by: Paul Pak <paulpak58@gmail.com>
diegocastanibm pushed a commit to diegocastanibm/vllm that referenced this pull request Aug 15, 2025
…lifecycle` (vllm-project#22727)

Signed-off-by: NickLucche <nlucches@redhat.com>
Signed-off-by: Diego-Castan <diego.castan@ibm.com>
yiliu30 pushed a commit to yiliu30/vllm-fork that referenced this pull request Aug 19, 2025
…lifecycle` (vllm-project#22727)

Signed-off-by: NickLucche <nlucches@redhat.com>
epwalsh pushed a commit to epwalsh/vllm that referenced this pull request Aug 28, 2025
…lifecycle` (vllm-project#22727)

Signed-off-by: NickLucche <nlucches@redhat.com>
xiao-llm pushed a commit to xiao-llm/vllm that referenced this pull request Aug 28, 2025
…lifecycle` (vllm-project#22727)

Signed-off-by: NickLucche <nlucches@redhat.com>
Signed-off-by: Xiao Yu <xiao.yu@amd.com>
zhewenl pushed a commit to zhewenl/vllm that referenced this pull request Aug 28, 2025
…lifecycle` (vllm-project#22727)

Signed-off-by: NickLucche <nlucches@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed v1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants