-
-
Notifications
You must be signed in to change notification settings - Fork 11.4k
[gpt-oss] Add test for response API + harmony (but skipped) #22554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Chen Zhang <[email protected]>
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds a comprehensive test suite for the new response API with harmony. The tests are currently skipped. My review focuses on correctness. I found an issue in test_function_calling_full_history where the conversation history is built incorrectly, which would cause the test to fail. I've provided a suggestion to fix it.
|
Let's wait until entrypoint test is passed to ensure it doesn't break this test |
…ject#22554) Signed-off-by: Chen Zhang <[email protected]> Signed-off-by: Paul Pak <[email protected]>
…ject#22554) Signed-off-by: Chen Zhang <[email protected]> Signed-off-by: Diego-Castan <[email protected]>
…ject#22554) Signed-off-by: Chen Zhang <[email protected]>
…ject#22554) Signed-off-by: Chen Zhang <[email protected]>
…ject#22554) Signed-off-by: Chen Zhang <[email protected]> Signed-off-by: Xiao Yu <[email protected]>
…ject#22554) Signed-off-by: Chen Zhang <[email protected]>
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.Purpose
Add test for response API + harmony. Note that as main branch doesn't support gpt-oss, all tests are skipped for now. And the test is a bit weak. May need more help on improving coverage and adding stronger assertions. These tests should be run with
Test Plan
Run it locally
Test Result
Pass after #22512
(Optional) Documentation Update