-
-
Notifications
You must be signed in to change notification settings - Fork 11.3k
Add H20-3e fused MoE kernel tuning configs for GLM-4.5 #22433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add H20-3e fused MoE kernel tuning configs for GLM-4.5 #22433
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds a new fused MoE kernel tuning configuration for the NVIDIA H20-3e GPU, specifically for the GLM-4.5 model. The new configuration file is generated from a tuning process, and the included benchmark results clearly demonstrate a performance improvement with increased request and token throughput. The changes are well-documented, and the new configuration file adheres to the project's existing format and naming conventions. The pull request is a valuable performance enhancement and is ready for merging.
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
jeejeelee
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you
|
@DarkLight1337 The CI documentation failure seems unrelated to this PR. |
Signed-off-by: shaojunqi <[email protected]>
57f4e1d to
8173fd5
Compare
…22433) Signed-off-by: shaojunqi <[email protected]> Co-authored-by: shaojunqi <[email protected]> Signed-off-by: Jinzhen Lin <[email protected]>
…22433) Signed-off-by: shaojunqi <[email protected]> Co-authored-by: shaojunqi <[email protected]> Signed-off-by: Noam Gat <[email protected]>
…22433) Signed-off-by: shaojunqi <[email protected]> Co-authored-by: shaojunqi <[email protected]> Signed-off-by: Paul Pak <[email protected]>
…22433) Signed-off-by: shaojunqi <[email protected]> Co-authored-by: shaojunqi <[email protected]> Signed-off-by: Diego-Castan <[email protected]>
…22433) Signed-off-by: shaojunqi <[email protected]> Co-authored-by: shaojunqi <[email protected]>
…22433) Signed-off-by: shaojunqi <[email protected]> Co-authored-by: shaojunqi <[email protected]> Signed-off-by: Xiao Yu <[email protected]>
…22433) Signed-off-by: shaojunqi <[email protected]> Co-authored-by: shaojunqi <[email protected]>
Essential Elements of an Effective PR Description Checklist
Purpose
H20-3e is H20 GPU with 141G memory. Add Moe tuning configs for GLM-4.5
Test Plan
Tuning command:
Deploy GLM-4.5:
Benchmark:
Test Result
Results without Moe tuning:
Results with Moe tuning: