-
-
Notifications
You must be signed in to change notification settings - Fork 11.3k
[Doc] Fix link to prefix caching design #22384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Yong Hoon Shin <[email protected]>
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request resolves a broken link in the Automatic Prefix Caching documentation. The updated link correctly directs to the prefix_caching.md design document. The change is accurate and improves the documentation's usability. The fix is correct as is, and I have no further recommendations.
|
Good catch, this was linking to the old V0 version which no longer exists |
Signed-off-by: Yong Hoon Shin <[email protected]> Signed-off-by: Jinzhen Lin <[email protected]>
Signed-off-by: Yong Hoon Shin <[email protected]> Signed-off-by: Noam Gat <[email protected]>
Signed-off-by: Yong Hoon Shin <[email protected]> Signed-off-by: Paul Pak <[email protected]>
Signed-off-by: Yong Hoon Shin <[email protected]> Signed-off-by: Diego-Castan <[email protected]>
Signed-off-by: Yong Hoon Shin <[email protected]>
Signed-off-by: Yong Hoon Shin <[email protected]> Signed-off-by: Xiao Yu <[email protected]>
Signed-off-by: Yong Hoon Shin <[email protected]>
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.Purpose
Link to prefix caching design in https://docs.vllm.ai/en/latest/features/automatic_prefix_caching.html doesn't work. Fixes link to correct markdown.
Test Plan
CI
Test Result
CI