Skip to content

Conversation

@sarckk
Copy link
Collaborator

@sarckk sarckk commented Aug 6, 2025

Essential Elements of an Effective PR Description Checklist

  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • [] (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.

Purpose

Link to prefix caching design in https://docs.vllm.ai/en/latest/features/automatic_prefix_caching.html doesn't work. Fixes link to correct markdown.

Test Plan

CI

Test Result

CI

@sarckk sarckk requested a review from hmellor as a code owner August 6, 2025 18:52
@github-actions
Copy link

github-actions bot commented Aug 6, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the documentation Improvements or additions to documentation label Aug 6, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request resolves a broken link in the Automatic Prefix Caching documentation. The updated link correctly directs to the prefix_caching.md design document. The change is accurate and improves the documentation's usability. The fix is correct as is, and I have no further recommendations.

@hmellor
Copy link
Member

hmellor commented Aug 6, 2025

Good catch, this was linking to the old V0 version which no longer exists

@vllm-project vllm-project locked and limited conversation to collaborators Aug 6, 2025
@vllm-project vllm-project unlocked this conversation Aug 6, 2025
@vllm-bot vllm-bot merged commit 5e83988 into vllm-project:main Aug 7, 2025
14 of 16 checks passed
jinzhen-lin pushed a commit to jinzhen-lin/vllm that referenced this pull request Aug 9, 2025
noamgat pushed a commit to noamgat/vllm that referenced this pull request Aug 9, 2025
paulpak58 pushed a commit to paulpak58/vllm that referenced this pull request Aug 13, 2025
diegocastanibm pushed a commit to diegocastanibm/vllm that referenced this pull request Aug 15, 2025
epwalsh pushed a commit to epwalsh/vllm that referenced this pull request Aug 28, 2025
xiao-llm pushed a commit to xiao-llm/vllm that referenced this pull request Aug 28, 2025
zhewenl pushed a commit to zhewenl/vllm that referenced this pull request Aug 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation force-merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants