-
-
Notifications
You must be signed in to change notification settings - Fork 11.3k
[BugFix] Fix FA2 RuntimeError when sinks is provided #22365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: LucasWilkinson <[email protected]>
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request resolves a RuntimeError in the FlashAttention 2 C++ extension by updating the vllm-flash-attn dependency to a specific commit that contains the necessary bug fix. The change is correct and well-contained. The approach of updating the GIT_TAG in the CMake build configuration is appropriate for incorporating this fix. The PR appears solid and ready for merging.
DarkLight1337
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick fix!
) Signed-off-by: LucasWilkinson <[email protected]> Signed-off-by: avtc <[email protected]>
) Signed-off-by: LucasWilkinson <[email protected]> Signed-off-by: Jinzhen Lin <[email protected]>
) Signed-off-by: LucasWilkinson <[email protected]> Signed-off-by: Noam Gat <[email protected]>
) Signed-off-by: LucasWilkinson <[email protected]>
) Signed-off-by: LucasWilkinson <[email protected]> Signed-off-by: Paul Pak <[email protected]>
) Signed-off-by: LucasWilkinson <[email protected]> Signed-off-by: Diego-Castan <[email protected]>
) Signed-off-by: LucasWilkinson <[email protected]>
) Signed-off-by: LucasWilkinson <[email protected]> Signed-off-by: Xiao Yu <[email protected]>
) Signed-off-by: LucasWilkinson <[email protected]>
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.Purpose
fix
introduced in vllm-project/flash-attention#75
Test Plan
test on A100 before and after PR
Test Result
before vllm crashes on first request; after this PR its fine
(Optional) Documentation Update