Skip to content

[Fix] Fix llama4 modelopt weight loading error #22107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vllm-bot merged 2 commits into from
Aug 3, 2025
Merged

[Fix] Fix llama4 modelopt weight loading error #22107

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5ab1e7d
fix llama4 modelopt weight loading
jiahanc Aug 1, 2025
8558d1f
Merge branch 'main' into jiahanc/fix_Llama4_ModelOpt
mgoin Aug 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions vllm/model_executor/models/mllama4.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -906,11 +906,13 @@ def _consolidate_qkv_weights(
def _rename_weight_for_modelopt_checkpoint(self, name: str) -> str:
"""Rename weights from ModelOpt llama4 fp8 checkpoints to vLLM
format."""
if name.startswith("model."):
if name.startswith("model.") or name.startswith(
"language_model.model."):
renamed = name.replace("model.", "language_model.model.",
1) if name.startswith("model.") else name
# Handle expert scale parameters with flat naming
if "feed_forward.experts." in name and ("_input_scale" in name or
"_weight_scale" in name):
renamed = name.replace("model.", "language_model.model.", 1)
# Map checkpoint naming to vLLM's expected naming
if "down_proj_input_scale" in renamed:
return renamed.replace("down_proj_input_scale",
Expand All @@ -929,15 +931,14 @@ def _rename_weight_for_modelopt_checkpoint(self, name: str) -> str:
# Handle attention scale parameters
elif "self_attn." in name and (".k_scale" in name
or ".v_scale" in name):
renamed = name.replace("model.", "language_model.model.", 1)
if ".k_proj.k_scale" in renamed:
return renamed.replace(".k_proj.k_scale", ".attn.k_scale")
elif ".v_proj.v_scale" in renamed:
return renamed.replace(".v_proj.v_scale", ".attn.v_scale")
return renamed

# Standard model.* to language_model.model.* renaming
return name.replace("model.", "language_model.model.", 1)
return renamed

elif name.startswith("lm_head.weight"):
return name.replace("lm_head.weight",
Expand Down