[DO NOT MERGE] Enable HF processing on GPU#22070
[DO NOT MERGE] Enable HF processing on GPU#22070DarkLight1337 wants to merge 174 commits intovllm-project:mainfrom
Conversation
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
There was a problem hiding this comment.
Code Review
This pull request enables Hugging Face processor execution on the GPU, a valuable performance enhancement. The changes include comprehensive documentation updates, new tests to validate the functionality, and significant refactoring to support the new feature.
The core logic for GPU processing, including moving data to and from the device and handling configuration, appears correct. The refactoring in the worker and test files improves code clarity and maintainability.
I've identified a couple of high-severity issues related to inefficient dummy data generation during profiling runs in both the GPU and TPU model runners. These inefficiencies could impact the accuracy of memory profiling and should be addressed. My review includes specific suggestions to resolve these issues.
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
|
This pull request has merge conflicts that must be resolved before it can be |
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
|
Hi @DarkLight1337, the pre-commit checks have failed. Please run: uv pip install pre-commit
pre-commit install
pre-commit run --all-filesThen, commit the changes and push to your branch. For future commits, Tip Is
|
|
This pull request has merge conflicts that must be resolved before it can be |
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.Purpose
This PR completes the basic features of #21995 with documentation and tests for it.
Test Plan
Added entrypoints tests to test the functionality.
Test Result
(Optional) Documentation Update