-
-
Notifications
You must be signed in to change notification settings - Fork 11.3k
[CI] Parallelize Kernels MoE Test #21764
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Parallelize Kernels MoE Test #21764
Conversation
Signed-off-by: mgoin <[email protected]>
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request aims to speed up the CI by parallelizing the Kernels MoE Test. The changes in the Buildkite pipeline configuration correctly add the parallelism attribute and the necessary pytest sharding flags.
However, I've identified a critical issue with the implementation of test sharding. The Buildkite environment variable BUILDKITE_PARALLEL_JOB is 0-indexed, while the pytest-shard plugin (which is likely being used here) expects a 1-indexed --shard-id. This mismatch will cause the first parallel job to fail, preventing a significant portion of the tests from running and breaking the build. I've provided suggestions to correct this for both the newly parallelized MoE test and an existing quantization test that has the same issue.
Signed-off-by: mgoin <[email protected]>
Signed-off-by: mgoin <[email protected]> Signed-off-by: x22x22 <[email protected]>
Signed-off-by: mgoin <[email protected]>
Signed-off-by: mgoin <[email protected]>
Signed-off-by: mgoin <[email protected]> Signed-off-by: Jinzhen Lin <[email protected]>
Signed-off-by: mgoin <[email protected]> Signed-off-by: Noam Gat <[email protected]>
Signed-off-by: mgoin <[email protected]> Signed-off-by: Paul Pak <[email protected]>
Signed-off-by: mgoin <[email protected]> Signed-off-by: Diego-Castan <[email protected]>
Signed-off-by: mgoin <[email protected]>
Signed-off-by: mgoin <[email protected]>
Purpose
The
Kernels MoE Testtakes 3 hours now, so let's at least split it in half.https://buildkite.com/vllm/ci/builds/25087/steps/canvas?sid=01984c37-20b7-47a1-b05e-6b3f88102b93

Test Plan
CI