Skip to content

Conversation

@mgoin
Copy link
Member

@mgoin mgoin commented Jul 28, 2025

Purpose

The Kernels MoE Test takes 3 hours now, so let's at least split it in half.

https://buildkite.com/vllm/ci/builds/25087/steps/canvas?sid=01984c37-20b7-47a1-b05e-6b3f88102b93
Screenshot 2025-07-28 at 10 38 25 AM

Test Plan

CI

@mergify mergify bot added the ci/build label Jul 28, 2025
@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to speed up the CI by parallelizing the Kernels MoE Test. The changes in the Buildkite pipeline configuration correctly add the parallelism attribute and the necessary pytest sharding flags.

However, I've identified a critical issue with the implementation of test sharding. The Buildkite environment variable BUILDKITE_PARALLEL_JOB is 0-indexed, while the pytest-shard plugin (which is likely being used here) expects a 1-indexed --shard-id. This mismatch will cause the first parallel job to fail, preventing a significant portion of the tests from running and breaking the build. I've provided suggestions to correct this for both the newly parallelized MoE test and an existing quantization test that has the same issue.

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) July 28, 2025 14:43
@DarkLight1337 DarkLight1337 added the ready ONLY add when PR is ready to merge/full CI is needed label Jul 28, 2025
@vllm-bot vllm-bot merged commit afa2607 into vllm-project:main Jul 29, 2025
100 of 105 checks passed
@mgoin mgoin deleted the parallelize-moe-kernel-test branch July 29, 2025 02:04
liuyumoye pushed a commit to liuyumoye/vllm that referenced this pull request Jul 31, 2025
x22x22 pushed a commit to x22x22/vllm that referenced this pull request Aug 5, 2025
Pradyun92 pushed a commit to Pradyun92/vllm that referenced this pull request Aug 6, 2025
npanpaliya pushed a commit to odh-on-pz/vllm-upstream that referenced this pull request Aug 6, 2025
jinzhen-lin pushed a commit to jinzhen-lin/vllm that referenced this pull request Aug 9, 2025
noamgat pushed a commit to noamgat/vllm that referenced this pull request Aug 9, 2025
paulpak58 pushed a commit to paulpak58/vllm that referenced this pull request Aug 13, 2025
diegocastanibm pushed a commit to diegocastanibm/vllm that referenced this pull request Aug 15, 2025
epwalsh pushed a commit to epwalsh/vllm that referenced this pull request Aug 28, 2025
zhewenl pushed a commit to zhewenl/vllm that referenced this pull request Aug 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/build ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants