Conversation
WoosukKwon
requested review from
KuntaiDu,
alexm-redhat,
comaniac,
njhill,
robertgshaw2-redhat,
simon-mo,
youkaichao and
zhuohan123
as code owners
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request is a large-scale effort to deprecate and remove V0 code, which is reflected in the numerous file deletions and updates to the CI pipeline. The changes look good and are consistent with the goal of deprecating V0.
I have one piece of feedback regarding a commented-out test in the Buildkite pipeline configuration. Commenting out tests can obscure potential issues, so it's better to either remove them if they're obsolete or add a TODO to track their re-enablement.
| # - label: Encoder Decoder tests # 5min | ||
| # mirror_hardwares: [amdexperimental, amdproduction] | ||
| # source_file_dependencies: | ||
| # - vllm/ | ||
| # - tests/encoder_decoder | ||
| # commands: | ||
| # - pytest -v -s encoder_decoder |
There was a problem hiding this comment.
Commenting out tests is generally discouraged as it can hide breakages and regressions. If these Encoder Decoder tests are temporarily disabled, it would be better to add a TODO with a ticket number to track re-enabling them. If they are no longer needed as part of the V0 deprecation, they should be removed entirely to keep the pipeline configuration clean.
Signed-off-by: Woosuk Kwon <woosuk.kwon@berkeley.edu>
Signed-off-by: Woosuk Kwon <woosuk.kwon@berkeley.edu>
|
This pull request has merge conflicts that must be resolved before it can be |
2 participants
No description provided.