-
-
Notifications
You must be signed in to change notification settings - Fork 11.3k
[Doc] Add FusedMoE Modular Kernel Documentation #21623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds documentation for the FusedMoE Modular Kernel. The documentation is comprehensive and provides a good overview of the architecture. I've identified a few high-impact issues to improve clarity and correctness: there are some recurring typos in key class names, and a couple of tables are not formatted correctly in Markdown, which hinders readability. The suggested changes should address these points.
docs/assets/design/fused_moe_modular_kernel/prepare_and_finalize_blocks.png
Outdated
Show resolved
Hide resolved
|
@bnellnm PTAL! Thanks 🙌 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should elaborate on this section for a bit.
|
I think there should be a brief description of the contiguous vs. batched formats at the beginning. I don't think it's obvious what the batched format is unless you've been working on MoE stuff already. |
Done 👍 Please take a look 🙌 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's important to note that layer.py sets self.fused_experts to the fused moe object and that the subclass needs to use this in it's own apply method.
bnellnm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks! Just one final comment about init_prepare_finalize.
|
Here's the rendered page preview https://vllm--21623.org.readthedocs.build/en/21623/design/fused_moe_modular_kernel.html If you use a level 1 heading in the MD I believe the title will be capitalised properly |
@hmellor done 👍 Please let me know if you see more issues. Thanks. |
|
Sorry, I meant if you title it # Fused MoE Modular Kernels |
Signed-off-by: Varun Sundar Rabindranath <[email protected]>
Signed-off-by: Varun Sundar Rabindranath <[email protected]>
Signed-off-by: Varun Sundar Rabindranath <[email protected]>
Signed-off-by: Varun Sundar Rabindranath <[email protected]>
Signed-off-by: Varun Sundar Rabindranath <[email protected]>
Signed-off-by: Varun Sundar Rabindranath <[email protected]>
Signed-off-by: Varun Sundar Rabindranath <[email protected]>
Signed-off-by: Varun Sundar Rabindranath <[email protected]>
Signed-off-by: Varun Sundar Rabindranath <[email protected]>
Signed-off-by: Varun Sundar Rabindranath <[email protected]>
Signed-off-by: Varun Sundar Rabindranath <[email protected]>
Signed-off-by: Varun Sundar Rabindranath <[email protected]>
3524f30 to
69ff21a
Compare
hmellor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is the rendered preview: https://vllm--21623.org.readthedocs.build/en/21623/design/fused_moe_modular_kernel.html. Lots of things aren't rendering correctly
Signed-off-by: Varun Sundar Rabindranath <[email protected]>
|
Thanks @hmellor - Sorry you had to go through the entire documents. I believe things should be fixed now. |
Signed-off-by: Varun Sundar Rabindranath <[email protected]>
|
Thanks for making those fixes, I've replied in the thread about the |
Signed-off-by: Varun Sundar Rabindranath <[email protected]>
Signed-off-by: Varun Sundar Rabindranath <[email protected]> Co-authored-by: Varun Sundar Rabindranath <[email protected]>
Signed-off-by: Varun Sundar Rabindranath <[email protected]> Co-authored-by: Varun Sundar Rabindranath <[email protected]> Signed-off-by: x22x22 <[email protected]>
Signed-off-by: Varun Sundar Rabindranath <[email protected]> Co-authored-by: Varun Sundar Rabindranath <[email protected]>
Signed-off-by: Varun Sundar Rabindranath <[email protected]> Co-authored-by: Varun Sundar Rabindranath <[email protected]> Signed-off-by: Jinzhen Lin <[email protected]>
Signed-off-by: Varun Sundar Rabindranath <[email protected]> Co-authored-by: Varun Sundar Rabindranath <[email protected]> Signed-off-by: Noam Gat <[email protected]>
Signed-off-by: Varun Sundar Rabindranath <[email protected]> Co-authored-by: Varun Sundar Rabindranath <[email protected]> Signed-off-by: Paul Pak <[email protected]>
Signed-off-by: Varun Sundar Rabindranath <[email protected]> Co-authored-by: Varun Sundar Rabindranath <[email protected]> Signed-off-by: Diego-Castan <[email protected]>
Signed-off-by: Varun Sundar Rabindranath <[email protected]> Co-authored-by: Varun Sundar Rabindranath <[email protected]>
Signed-off-by: Varun Sundar Rabindranath <[email protected]> Co-authored-by: Varun Sundar Rabindranath <[email protected]>
Purpose
Documentation for FusedMoEModularKernel
Test Plan
None
Test Result
None