[Docs] Factor out troubleshooting to its own guide; add section for Ray Observability #21578
Conversation
…ay Observability Signed-off-by: Ricardo Decal <[email protected]>
Signed-off-by: Ricardo Decal <[email protected]>
Signed-off-by: Ricardo Decal <[email protected]>
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the troubleshooting documentation by moving it to a new, dedicated guide and adding a section on Ray Observability. The changes are well-structured, but I've found a couple of instances of duplicated content in the new troubleshooting guide that should be removed to improve clarity.
Signed-off-by: Ricardo Decal <[email protected]>
…xplanation of what is gpudirect rdma Signed-off-by: Ricardo Decal <[email protected]>
Signed-off-by: Ricardo Decal <[email protected]>
crypdick
changed the title
…ure work. Signed-off-by: Ricardo Decal <[email protected]>
hmellor
left a comment
hmellor
left a comment
There was a problem hiding this comment.
One nit about no title in the original doc. Other than that this LGTM
Signed-off-by: Ricardo Decal <[email protected]>
|
( |
Signed-off-by: Ricardo Decal <[email protected]>
Signed-off-by: Ricardo Decal <[email protected]>
Signed-off-by: Ricardo Decal <[email protected]>
Signed-off-by: Ricardo Decal <[email protected]>
|
Apologies @hmellor, that's my fault. I asked Richard to add the label because I had addressed all the PR feedback and thought it was ready for merge. |
Signed-off-by: Ricardo Decal <[email protected]>
hmellor
left a comment
hmellor
left a comment
There was a problem hiding this comment.
LGTM, thanks for the documentation improvement
…ay Observability (vllm-project#21578) Signed-off-by: Ricardo Decal <[email protected]> Signed-off-by: Jinzhen Lin <[email protected]>
…ay Observability (vllm-project#21578) Signed-off-by: Ricardo Decal <[email protected]> Signed-off-by: Noam Gat <[email protected]>
…ay Observability (vllm-project#21578) Signed-off-by: Ricardo Decal <[email protected]> Signed-off-by: Paul Pak <[email protected]>
…ay Observability (vllm-project#21578) Signed-off-by: Ricardo Decal <[email protected]> Signed-off-by: Diego-Castan <[email protected]>
…ay Observability (vllm-project#21578) Signed-off-by: Ricardo Decal <[email protected]>
…ay Observability (vllm-project#21578) Signed-off-by: Ricardo Decal <[email protected]> Signed-off-by: Xiao Yu <[email protected]>
…ay Observability (vllm-project#21578) Signed-off-by: Ricardo Decal <[email protected]>
5 participants
Purpose
Splits out the distributed troubleshooting section from the serving guide, and expand it with a short section on Ray Observability tools.