Skip to content

Conversation

@chaunceyjiang
Copy link
Collaborator

@chaunceyjiang chaunceyjiang commented Jul 23, 2025

Essential Elements of an Effective PR Description Checklist

  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.

Supports #21423

Purpose

Test Result

CUDA:
TP=4

# export VLLM_PROCESS_NAME_PREFIX=VLLM
# vllm serve /home/jovyan/qwen3-8b  -tp 2
# ps -ef
root       15593    9259 17 15:08 pts/4    00:00:13 VLLM::APIServer_0
root       15954   15593  0 15:09 pts/4    00:00:00 /opt/conda/envs/vllm/bin/python3.12 -c from multiprocessing.resource_trac
root       15955   15593 19 15:09 pts/4    00:00:11 VLLM::EngineCoreProc_0
root       16120   15955 33 15:09 pts/4    00:00:16 VLLM::Worker_TP0_DP0
root       16124   15955 37 15:09 pts/4    00:00:18 VLLM::Worker_TP1_DP0
root       16125   15955 35 15:09 pts/4    00:00:17 VLLM::Worker_TP2_DP0
root       16126   15955 33 15:09 pts/4    00:00:16 VLLM::Worker_TP3_DP0

DP=2

# export VLLM_PROCESS_NAME_PREFIX=VLLM
# vllm serve /home/jovyan/qwen3-8b  --data-parallel-size 2 --data-parallel-rpc-port 25555 --data-parallel-address 127.0.0.1 --api-server-count 2
# ps -ef
root      116630     734 13 10:55 pts/4    00:00:10 VLLM::APIServerProcessManager
root      117014  116630  0 10:55 pts/4    00:00:00 /opt/conda/envs/vllm/bin/python3.12 -c from multiprocessing.resource_tracker import main;main(36)
root      117015  116630 17 10:55 pts/4    00:00:10 VLLM::DPCoordinatorProc
root      117018  116630 94 10:55 pts/4    00:00:57 VLLM::DPEngineCoreProc_0
root      117019  116630 92 10:55 pts/4    00:00:56 VLLM::DPEngineCoreProc_1
root      117020  116630 18 10:55 pts/4    00:00:11 VLLM::APIServer_0
root      117021  116630 20 10:55 pts/4    00:00:12 VLLM::APIServer_1

TP=2. DP=2

# export VLLM_PROCESS_NAME_PREFIX=VLLM
# vllm serve /home/jovyan/qwen3-8b --enable-auto-tool-choice --tool-call-parser hermes --reasoning-parser qwen3 --disable-log-requests --data-parallel-size 2 --data-parallel-rpc-port 25555 --data-parallel-address 127.0.0.1 --api-server-count 2 --gpu-memory-utilization 0.4 --data-parallel-size-local 0
# vllm serve /home/jovyan/qwen3-8b --enable-auto-tool-choice --tool-call-parser hermes --reasoning-parser qwen3 --disable-log-requests --data-parallel-size 2 --data-parallel-rpc-port 25555 --data-parallel-address 127.0.0.1 --headless --gpu-memory-utilization 0.4 --data-parallel-size-local 2  -tp 2

root        6441    4359 10 15:01 pts/3    00:00:10 VLLM::APIServer_Headless
root        7046    6441  0 15:01 pts/3    00:00:00 /opt/conda/envs/vllm/bin/python3.12 -c from multiprocessing.resource_trac
root        7047    6441 13 15:01 pts/3    00:00:10 VLLM::DPEngineCoreProc_0
root        7048    6441 14 15:01 pts/3    00:00:11 VLLM::DPEngineCoreProc_1
root        7720    2688 21 15:02 pts/2    00:00:09 VLLM::APIServerProcessManager
root        8040    7720  0 15:02 pts/2    00:00:00 /opt/conda/envs/vllm/bin/python3.12 -c from multiprocessing.resource_trac
root        8041    7720 28 15:02 pts/2    00:00:09 VLLM::DPCoordinatorProc
root        8044    7720 31 15:02 pts/2    00:00:10 VLLM::APIServer_0
root        8045    7720 30 15:02 pts/2    00:00:10 VLLM::APIServer_1
root        8058    7048 37 15:02 pts/3    00:00:12 VLLM::Worker_TP0_DP1
root        8061    7047 38 15:02 pts/3    00:00:12 VLLM::Worker_TP0_DP0
root        8062    7048 38 15:02 pts/3    00:00:12 VLLM::Worker_TP1_DP1
root        8063    7047 37 15:02 pts/3    00:00:12 VLLM::Worker_TP1_DP0


nvidia-smi

+---------------------------------------------------------------------------------------+
| Processes:                                                                            |
|  GPU   GI   CI        PID   Type   Process name                            GPU Memory |
|        ID   ID                                                             Usage      |
|=======================================================================================|
|    0   N/A  N/A   1357293      C   VLLM::Worker_TP0_DP0                      36282MiB |
|    1   N/A  N/A   1357295      C   VLLM::Worker_TP1_DP0                      36282MiB |
|    2   N/A  N/A   1357290      C   VLLM::Worker_TP0_DP1                      36282MiB |
|    4   N/A  N/A   1357294      C   VLLM::Worker_TP1_DP1                      36282MiB |

Note: The process python3.12 -c from multiprocessing.resource_tracker import main;main(36) is automatically generated when using from multiprocessing import shared_memory, so there is currently no way to modify its process name.


Keep the process name consistent with the naming style of SGlang processes.

image

@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a feature to allow custom naming of vLLM processes via the VLLM_PROCESS_NAME_PREFIX environment variable, which is useful for monitoring. The implementation uses the setproctitle library across different vLLM components. My main concern is that setproctitle is a new dependency that needs to be added to the project's dependency files to avoid runtime errors.

@mergify mergify bot added the ci/build label Jul 23, 2025
@chaunceyjiang
Copy link
Collaborator Author

/cc @DarkLight1337 @njhill @ciaoyizhen PTAL.

Copy link
Member

@njhill njhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @chaunceyjiang I wasn't aware it was so easy to do this!

@chaunceyjiang chaunceyjiang requested a review from njhill July 23, 2025 15:14
Copy link

@ciaoyizhen ciaoyizhen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't believe it, it turned out even better than I expected.

@DarkLight1337
Copy link
Member

Please fix doc build

Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM given tests pass

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) July 24, 2025 07:12
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Jul 24, 2025
@vllm-bot vllm-bot merged commit 6da0078 into vllm-project:main Jul 24, 2025
105 of 106 checks passed
@chaunceyjiang chaunceyjiang deleted the process_name branch July 24, 2025 10:41
@huydhn
Copy link
Contributor

huydhn commented Jul 26, 2025

This change actually causes the benchmark jobs to time out because VLLM processes now have a different name with VLLM prefix. I have the fix at #21641

njhill added a commit to njhill/vllm that referenced this pull request Jul 28, 2025
Follow-on from vllm-project#21445 which I hadn't finished reviewing.

- Rename method from "bind process name" to "set process title" which is clearer imo.
- Choose process names more carefully, decouple from class names.
- Correctly include/order DP/PP/TP ranks in worker proc names.
- Don't change the title of the top-level processes (which may be confusing to administrators who expect it to match the command line).
- [Related] Add APIServer process logging prefix in single-API-server case to match multi-api-server log appearance.

Signed-off-by: Nick Hill <[email protected]>
@njhill
Copy link
Member

njhill commented Jul 28, 2025

FYI I've opened a follow-on PR for this: #21780

x22x22 pushed a commit to x22x22/vllm that referenced this pull request Aug 5, 2025
Pradyun92 pushed a commit to Pradyun92/vllm that referenced this pull request Aug 6, 2025
npanpaliya pushed a commit to odh-on-pz/vllm-upstream that referenced this pull request Aug 6, 2025
jinzhen-lin pushed a commit to jinzhen-lin/vllm that referenced this pull request Aug 9, 2025
paulpak58 pushed a commit to paulpak58/vllm that referenced this pull request Aug 13, 2025
diegocastanibm pushed a commit to diegocastanibm/vllm that referenced this pull request Aug 15, 2025
epwalsh pushed a commit to epwalsh/vllm that referenced this pull request Aug 28, 2025
wangxiyuan pushed a commit to vllm-project/vllm-ascend that referenced this pull request Sep 7, 2025
### What this PR does / why we need it?
vLLM now names the process with VLLM prefix after
vllm-project/vllm#21445, we should kill the
correct process name after one iteration benchmark to avoid OOM issue
### Does this PR introduce _any_ user-facing change?

### How was this patch tested?

- vLLM version: v0.10.1.1
- vLLM main:
vllm-project/vllm@e599e2c

---------

Signed-off-by: wangli <[email protected]>
Angazenn pushed a commit to Angazenn/vllm-ascend that referenced this pull request Sep 10, 2025
…m-project#2782)

### What this PR does / why we need it?
vLLM now names the process with VLLM prefix after
vllm-project/vllm#21445, we should kill the
correct process name after one iteration benchmark to avoid OOM issue
### Does this PR introduce _any_ user-facing change?

### How was this patch tested?

- vLLM version: v0.10.1.1
- vLLM main:
vllm-project/vllm@e599e2c

---------

Signed-off-by: wangli <[email protected]>
offline893 pushed a commit to offline893/vllm-ascend that referenced this pull request Sep 16, 2025
…m-project#2782)

### What this PR does / why we need it?
vLLM now names the process with VLLM prefix after
vllm-project/vllm#21445, we should kill the
correct process name after one iteration benchmark to avoid OOM issue
### Does this PR introduce _any_ user-facing change?

### How was this patch tested?

- vLLM version: v0.10.1.1
- vLLM main:
vllm-project/vllm@e599e2c

---------

Signed-off-by: wangli <[email protected]>
Signed-off-by: offline0806 <[email protected]>
wangxiaoteng888 pushed a commit to LCAIZJ/vllm-ascend that referenced this pull request Sep 25, 2025
…m-project#2782)

### What this PR does / why we need it?
vLLM now names the process with VLLM prefix after
vllm-project/vllm#21445, we should kill the
correct process name after one iteration benchmark to avoid OOM issue
### Does this PR introduce _any_ user-facing change?

### How was this patch tested?

- vLLM version: v0.10.1.1
- vLLM main:
vllm-project/vllm@e599e2c

---------

Signed-off-by: wangli <[email protected]>
chopper0126 pushed a commit to chopper0126/vllm-ascend that referenced this pull request Sep 26, 2025
…m-project#2782)

### What this PR does / why we need it?
vLLM now names the process with VLLM prefix after
vllm-project/vllm#21445, we should kill the
correct process name after one iteration benchmark to avoid OOM issue
### Does this PR introduce _any_ user-facing change?

### How was this patch tested?

- vLLM version: v0.10.1.1
- vLLM main:
vllm-project/vllm@e599e2c

---------

Signed-off-by: wangli <[email protected]>
Angazenn pushed a commit to Angazenn/vllm-ascend that referenced this pull request Oct 21, 2025
…m-project#2782)

### What this PR does / why we need it?
vLLM now names the process with VLLM prefix after
vllm-project/vllm#21445, we should kill the
correct process name after one iteration benchmark to avoid OOM issue
### Does this PR introduce _any_ user-facing change?

### How was this patch tested?

- vLLM version: v0.10.1.1
- vLLM main:
vllm-project/vllm@e599e2c

---------

Signed-off-by: wangli <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/build frontend ready ONLY add when PR is ready to merge/full CI is needed v1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants