Skip to content

[Bugfix][CUDA] fixes CUDA FP8 kv cache dtype supported #21420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 23, 2025
Merged

[Bugfix][CUDA] fixes CUDA FP8 kv cache dtype supported #21420

merged 1 commit into from
Jul 23, 2025

Conversation

@elvischenv
Copy link
Contributor

@elvischenv elvischenv commented Jul 23, 2025 •
edited by github-actions bot
Loading

Essential Elements of an Effective PR Description Checklist

  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.

Purpose

Previous PR(#21302) defined a class method is_kv_cache_dtype_supported() under NonNvmlCudaPlatform class, but NvmlCudaPlatform also needs this method.

So this PR moved the method to the parent class CudaPlatformBase.

Test Plan

Test Result

(Optional) Documentation Update

@elvischenv
fix cuda fp8 kv cache
8840037 
Signed-off-by: elvischenv <[email protected]>
@github-actions
Copy link

github-actions bot commented Jul 23, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

gemini-code-assist[bot]
gemini-code-assist bot reviewed Jul 23, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request correctly moves the is_kv_cache_dtype_supported method to the CudaPlatformBase class to be shared by subclasses. However, I found a logical issue in the method itself that could lead to incorrect behavior. I've provided a suggestion to fix this and improve the clarity of the code.

@elvischenv
Copy link
Contributor Author

elvischenv commented Jul 23, 2025

@mgoin @DarkLight1337 @pavanimajety for viz. Thanks.

mgoin
mgoin approved these changes Jul 23, 2025
View reviewed changes
Copy link
Member

@mgoin mgoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@mgoin mgoin enabled auto-merge (squash) July 23, 2025 00:12
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Jul 23, 2025
@vllm-bot vllm-bot merged commit 2dec7c1 into vllm-project:main Jul 23, 2025
74 of 75 checks passed
@elvischenv elvischenv deleted the elvischenv/fix-cuda-fp8-kv-cache branch July 23, 2025 03:43
zixi-qi pushed a commit to zixi-qi/vllm that referenced this pull request Jul 23, 2025
@elvischenv @zixi-qi
[Bugfix][CUDA] fixes CUDA FP8 kv cache dtype supported (vllm-project#…
44653f8 
…21420)

Signed-off-by: elvischenv <[email protected]>
Signed-off-by: qizixi <[email protected]>
x22x22 pushed a commit to x22x22/vllm that referenced this pull request Aug 5, 2025
@elvischenv @x22x22
[Bugfix][CUDA] fixes CUDA FP8 kv cache dtype supported (vllm-project#…
7763c2c 
…21420)

Signed-off-by: elvischenv <[email protected]>
Signed-off-by: x22x22 <[email protected]>
Pradyun92 pushed a commit to Pradyun92/vllm that referenced this pull request Aug 6, 2025
@elvischenv
[Bugfix][CUDA] fixes CUDA FP8 kv cache dtype supported (vllm-project#…
2dcf8e2 
…21420)

Signed-off-by: elvischenv <[email protected]>
npanpaliya pushed a commit to odh-on-pz/vllm-upstream that referenced this pull request Aug 6, 2025
@elvischenv @npanpaliya
[Bugfix][CUDA] fixes CUDA FP8 kv cache dtype supported (vllm-project#…
17e4e0d 
…21420)

Signed-off-by: elvischenv <[email protected]>
jinzhen-lin pushed a commit to jinzhen-lin/vllm that referenced this pull request Aug 9, 2025
@elvischenv @jinzhen-lin
[Bugfix][CUDA] fixes CUDA FP8 kv cache dtype supported (vllm-project#…
abbb14c 
…21420)

Signed-off-by: elvischenv <[email protected]>
Signed-off-by: Jinzhen Lin <[email protected]>
paulpak58 pushed a commit to paulpak58/vllm that referenced this pull request Aug 13, 2025
@elvischenv @paulpak58
[Bugfix][CUDA] fixes CUDA FP8 kv cache dtype supported (vllm-project#…
16eced0 
…21420)

Signed-off-by: elvischenv <[email protected]>
Signed-off-by: Paul Pak <[email protected]>
diegocastanibm pushed a commit to diegocastanibm/vllm that referenced this pull request Aug 15, 2025
@elvischenv @diegocastanibm
[Bugfix][CUDA] fixes CUDA FP8 kv cache dtype supported (vllm-project#…
ef7607a 
…21420)

Signed-off-by: elvischenv <[email protected]>
Signed-off-by: Diego-Castan <[email protected]>
epwalsh pushed a commit to epwalsh/vllm that referenced this pull request Aug 28, 2025
@elvischenv @epwalsh
[Bugfix][CUDA] fixes CUDA FP8 kv cache dtype supported (vllm-project#…
be6308d 
…21420)

Signed-off-by: elvischenv <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mgoin mgoin mgoin approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@elvischenv @mgoin @vllm-bot