-
-
Notifications
You must be signed in to change notification settings - Fork 15.7k
[WIP][RC] Update PyTorch to 2.8.0 #21320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
d6bf991
[WIP][RC] Update PyTorch to 2.8.0
huydhn 456985c
Handle xformers
huydhn 4838d53
Some more tweaks
huydhn ca21216
Attempt to fix xformers build
huydhn 0c43174
Silly typo
huydhn 14c85d1
Few more tweaks for a greener CI
huydhn ad98d10
Attempt to offload to CPU to avoid OOM in CI
huydhn 316f116
Merge branch 'main' into pytorch-2.8.0
huydhn 460ed09
Merge branch 'main' into pytorch-2.8.0
huydhn 7df288f
Merge branch 'main' into pytorch-2.8.0
huydhn 6a08113
Fix lint
huydhn 44f07c0
Run all test_sequence_parallel again
huydhn 29fb5a0
Typo
huydhn 6a7e3f8
Merge branch 'main' into pytorch-2.8.0
huydhn c5d8940
Try to reproduce OOM after recent rebase
huydhn f320d9d
Match xformers version
huydhn a5999e1
Not sure why building xformers 0.0.31 fails
huydhn d1dbb4e
Remove some doc changes what are not needed
huydhn 6f394f5
Tweak some tests
huydhn dffd84b
test_cudnn
atalman e1182c2
test
atalman 13e5ffa
cuda
atalman 81fc749
cudnn
atalman 9150d73
test
atalman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -18,7 +18,11 @@ apt autoremove -y | |||||||||||||
|
|
||||||||||||||
| echo 'import os; os.system("touch /tmp/changed.file")' >> vllm/__init__.py | ||||||||||||||
|
|
||||||||||||||
| VLLM_TEST_USE_PRECOMPILED_NIGHTLY_WHEEL=1 VLLM_USE_PRECOMPILED=1 pip3 install -vvv -e . | ||||||||||||||
| # TESTING, TO BE REMOVED | ||||||||||||||
| VLLM_TEST_USE_PRECOMPILED_NIGHTLY_WHEEL=1 VLLM_USE_PRECOMPILED=1 pip3 install -vvv -e . \ | ||||||||||||||
| --extra-index-url https://download.pytorch.org/whl/test/cu128 | ||||||||||||||
|
|
||||||||||||||
| pip3 install nvidia-cudnn-cu12==9.5.1.17 --force-reinstall | ||||||||||||||
|
Comment on lines
+21
to
+25
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. These changes are marked as temporary for testing and should be removed. Merging this would introduce test-specific logic into a test script that should reflect the final installation process. Please revert these changes to the original
Suggested change
|
||||||||||||||
|
|
||||||||||||||
| # Run the script | ||||||||||||||
| python3 -c 'import vllm' | ||||||||||||||
|
|
||||||||||||||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
DEBUGcomment and thepython3 -m xformers.infocommand appear to be for debugging purposes. Please remove them before merging to keep the Dockerfile clean.