[V1] [KVConnector] Fix MultiprocExecutor worker output aggregation#21048
Conversation
|
Warning Gemini encountered an error creating the review. You can try again by commenting |
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
219abfe to
2aa7589
Compare
Signed-off-by: David Ben-David <davidb@pliops.com>
Signed-off-by: David Ben-David <davidb@pliops.com>
2aa7589 to
042a898
Compare
…llm-project#21048) Signed-off-by: David Ben-David <davidb@pliops.com> Co-authored-by: David Ben-David <davidb@pliops.com> Signed-off-by: x22x22 <wadeking@qq.com>
…llm-project#21048) Signed-off-by: David Ben-David <davidb@pliops.com> Co-authored-by: David Ben-David <davidb@pliops.com>
…llm-project#21048) Signed-off-by: David Ben-David <davidb@pliops.com> Co-authored-by: David Ben-David <davidb@pliops.com>
…llm-project#21048) Signed-off-by: David Ben-David <davidb@pliops.com> Co-authored-by: David Ben-David <davidb@pliops.com> Signed-off-by: Jinzhen Lin <linjinzhen@hotmail.com>
…llm-project#21048) Signed-off-by: David Ben-David <davidb@pliops.com> Co-authored-by: David Ben-David <davidb@pliops.com> Signed-off-by: Paul Pak <paulpak58@gmail.com>
…llm-project#21048) Signed-off-by: David Ben-David <davidb@pliops.com> Co-authored-by: David Ben-David <davidb@pliops.com> Signed-off-by: Diego-Castan <diego.castan@ibm.com>
…llm-project#21048) Signed-off-by: David Ben-David <davidb@pliops.com> Co-authored-by: David Ben-David <davidb@pliops.com>
Purpose
Fix an issue in
MultiprocExecutorwhere thefinished_sendingandfinished_recvingfields in aggregated worker outputs were not correctly updated. This could wrongly propagate some requests as finished even when certain workers had not reported them yet.This PR also adds comprehensive unit tests for
_aggregate_workers_outputand_async_aggregate_workers_outputto ensure correct behavior in various scenarios.Test Plan
Run the new unit tests:
Test Result
All tests pass. Example output: