-
-
Notifications
You must be signed in to change notification settings - Fork 11.4k
[Misc] Clean up Aimv2 config registration in Ovis config #20921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Misc] Clean up Aimv2 config registration in Ovis config #20921
Conversation
Signed-off-by: Isotr0py <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @Isotr0py, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request resolves a configuration conflict with the aimv2 model, which is now natively supported in the transformers library's main branch. It cleans up the Ovis configuration by removing a redundant aimv2 registration and adjusts the model configuration loading logic to correctly instantiate AIMv2Config for aimv2 models, thereby preventing duplicate name errors and ensuring proper integration with the upstream transformers library.
Highlights
- Configuration Conflict Resolution: Removed the explicit
AutoConfig.register("aimv2", AIMv2Config)call invllm/transformers_utils/configs/ovis.py. This change directly addresses aValueErrorthat would occur due toaimv2being pre-registered in the upstreamtransformerslibrary, ensuring compatibility when using thetransformersmain branch. - Conditional
AIMv2ConfigInstantiation: Modified theOvisConfig's__init__method to specifically handleaimv2backbone configurations. Instead of relying onAutoConfig.for_model(which would now pick up the upstreamtransformerslibrary'saimv2config),AIMv2Configis now directly instantiated foraimv2models, while other model types continue to useAutoConfig.for_modelfor dynamic loading.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request removes the original AIMv2Config registration in Ovis config, resolving a duplicate model name issue. I've suggested a minor improvement for code consistency.
| if model_type != "aimv2": | ||
| backbone_config.pop('model_type') | ||
| backbone_config = AutoConfig.for_model(model_type, **backbone_config) | ||
| else: | ||
| backbone_config = AIMv2Config(**backbone_config) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider popping model_type from backbone_config before the conditional check for consistency. This ensures backbone_config is handled the same way in both branches and avoids passing unexpected keys to constructors.
| if model_type != "aimv2": | |
| backbone_config.pop('model_type') | |
| backbone_config = AutoConfig.for_model(model_type, **backbone_config) | |
| else: | |
| backbone_config = AIMv2Config(**backbone_config) | |
| model_type = backbone_config.pop('model_type') | |
| if model_type != "aimv2": | |
| backbone_config = AutoConfig.for_model(model_type, **backbone_config) | |
| else: | |
| backbone_config = AIMv2Config(**backbone_config) |
…t#20921) Signed-off-by: Isotr0py <[email protected]> Signed-off-by: x22x22 <[email protected]>
…t#20921) Signed-off-by: Isotr0py <[email protected]>
…t#20921) Signed-off-by: Isotr0py <[email protected]>
…t#20921) Signed-off-by: Isotr0py <[email protected]> Signed-off-by: Jinzhen Lin <[email protected]>
…t#20921) Signed-off-by: Isotr0py <[email protected]>
…t#20921) Signed-off-by: Isotr0py <[email protected]> Signed-off-by: Diego-Castan <[email protected]>
…t#20921) Signed-off-by: Isotr0py <[email protected]>
…t#20921) Signed-off-by: Isotr0py <[email protected]>
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.Purpose
AIMv2Configregistration in Ovis config porting to avoid duplicate model name:Test Plan
Test Result
(Optional) Documentation Update