Skip to content

Conversation

@QiliangCui
Copy link
Contributor

@QiliangCui QiliangCui commented Jul 13, 2025

Purpose

Re-enable accuracy test for google/gemma-3-1b-it accuracy on TPU by disabling huggingface xet.

Description

Load the test loads google/gemma-3-1b-it it hangs. huggingface verbose logs:

Request d4ac3eb5-9582-4c8a-bda8-050633b0e516: GET https://huggingface.co/api/models/google/gemma-3-1b-it/revision/main (authenticated: True)
DEBUG:huggingface_hub.utils._http:Request d4ac3eb5-9582-4c8a-bda8-050633b0e516: GET https://huggingface.co/api/models/google/gemma-3-1b-it/revision/main (authenticated: True)
Request c6d97010-4bdc-45f3-b6d5-3aea6365915c: HEAD https://huggingface.co/google/gemma-3-1b-it/resolve/dcc83ea841ab6100d6b47a070329e1ba4cf78752/model.safetensors (authenticated: True)
DEBUG:huggingface_hub.utils._http:Request c6d97010-4bdc-45f3-b6d5-3aea6365915c: HEAD https://huggingface.co/google/gemma-3-1b-it/resolve/dcc83ea841ab6100d6b47a070329e1ba4cf78752/model.safetensors (authenticated: True)
Downloading 'model.safetensors' to '/root/.cache/huggingface/hub/models--google--gemma-3-1b-it/blobs/3d4ef8d71c14db7e448a09ebe891cfb6bf32c57a9b44499ae0d1c098e48516b6.incomplete'
INFO:huggingface_hub.file_download:Downloading 'model.safetensors' to '/root/.cache/huggingface/hub/models--google--gemma-3-1b-it/blobs/3d4ef8d71c14db7e448a09ebe891cfb6bf32c57a9b44499ae0d1c098e48516b6.incomplete'
Xet Storage is enabled for this repo. Downloading file from Xet Storage..
DEBUG:huggingface_hub.file_download:Xet Storage is enabled for this repo. Downloading file from Xet Storage..
Request 29520666-b0fc-4512-aede-9591ac3e0aa4: GET https://huggingface.co/api/models/google/gemma-3-1b-it/xet-read-token/dcc83ea841ab6100d6b47a070329e1ba4cf78752 (authenticated: True)
DEBUG:huggingface_hub.utils._http:Request 29520666-b0fc-4512-aede-9591ac3e0aa4: GET https://huggingface.co/api/models/google/gemma-3-1b-it/xet-read-token/dcc83ea841ab6100d6b47a070329e1ba4cf78752 (authenticated: True)

I tried other ways like explicitly installing python3 -m pip install huggingface_hub[hf_xet] but i didn't work well: after doing it, it has more chances not hang to timeout but quickly and consistently gives Fatal Python error: Segmentation fault

Test Plan

Test on CI fast check.

Test Result

image

@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @QiliangCui, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on re-enabling a specific accuracy test for the google/gemma-3-1b-it model. The change involves removing the pytest.skip marker that was preventing the test from running and introducing an environment variable setting, likely to address the underlying issues that caused the test to be disabled previously. The author notes this is currently for CI testing.

Highlights

  • Test Re-enablement: The accuracy test for the google/gemma-3-1b-it model, which was previously temporarily disabled, has been re-enabled.
  • Environment Configuration: For the google/gemma-3-1b-it model's test run, the HF_HUB_DISABLE_XET environment variable is now explicitly set to "1".
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request re-enables the google/gemma-3-1b-it accuracy test, which was previously skipped due to failures. The change introduces an environment variable setting as a fix. My feedback focuses on improving code maintainability by adding a comment to explain this fix.

@DarkLight1337
Copy link
Member

It looks like the CI isn't blocked at lm_eval anymore

@QiliangCui
Copy link
Contributor Author

It looks like the CI isn't blocked at lm_eval anymore

Yes. The mitigation should work.

@vllm-bot vllm-bot merged commit 99b4f08 into vllm-project:main Jul 13, 2025
7 of 10 checks passed
@vanbasten23
Copy link
Collaborator

Thanks @QiliangCui for the fix!

x22x22 pushed a commit to x22x22/vllm that referenced this pull request Aug 5, 2025
Pradyun92 pushed a commit to Pradyun92/vllm that referenced this pull request Aug 6, 2025
npanpaliya pushed a commit to odh-on-pz/vllm-upstream that referenced this pull request Aug 6, 2025
jinzhen-lin pushed a commit to jinzhen-lin/vllm that referenced this pull request Aug 9, 2025
paulpak58 pushed a commit to paulpak58/vllm that referenced this pull request Aug 13, 2025
diegocastanibm pushed a commit to diegocastanibm/vllm that referenced this pull request Aug 15, 2025
epwalsh pushed a commit to epwalsh/vllm that referenced this pull request Aug 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants