-
-
Notifications
You must be signed in to change notification settings - Fork 11.3k
Renable google/gemma-3-1b-it accuracy test. #20866
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @QiliangCui, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request focuses on re-enabling a specific accuracy test for the google/gemma-3-1b-it model. The change involves removing the pytest.skip marker that was preventing the test from running and introducing an environment variable setting, likely to address the underlying issues that caused the test to be disabled previously. The author notes this is currently for CI testing.
Highlights
- Test Re-enablement: The accuracy test for the
google/gemma-3-1b-itmodel, which was previously temporarily disabled, has been re-enabled. - Environment Configuration: For the
google/gemma-3-1b-itmodel's test run, theHF_HUB_DISABLE_XETenvironment variable is now explicitly set to "1".
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request re-enables the google/gemma-3-1b-it accuracy test, which was previously skipped due to failures. The change introduces an environment variable setting as a fix. My feedback focuses on improving code maintainability by adding a comment to explain this fix.
|
It looks like the CI isn't blocked at |
Signed-off-by: Qiliang Cui <[email protected]>
Yes. The mitigation should work. |
|
Thanks @QiliangCui for the fix! |
Signed-off-by: Qiliang Cui <[email protected]> Signed-off-by: x22x22 <[email protected]>
Signed-off-by: Qiliang Cui <[email protected]>
Signed-off-by: Qiliang Cui <[email protected]>
Signed-off-by: Qiliang Cui <[email protected]> Signed-off-by: Jinzhen Lin <[email protected]>
Signed-off-by: Qiliang Cui <[email protected]> Signed-off-by: Paul Pak <[email protected]>
Signed-off-by: Qiliang Cui <[email protected]> Signed-off-by: Diego-Castan <[email protected]>
Signed-off-by: Qiliang Cui <[email protected]>
Purpose
Re-enable accuracy test for google/gemma-3-1b-it accuracy on TPU by disabling huggingface xet.
Description
Load the test loads
google/gemma-3-1b-itit hangs. huggingface verbose logs:I tried other ways like explicitly installing
python3 -m pip install huggingface_hub[hf_xet]but i didn't work well: after doing it, it has more chances not hang to timeout but quickly and consistently givesFatal Python error: Segmentation faultTest Plan
Test on CI fast check.
Test Result