Skip to content

Conversation

@jeejeelee
Copy link
Collaborator

@jeejeelee jeejeelee commented Jul 11, 2025

Essential Elements of an Effective PR Description Checklist

  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.

Purpose

Only need to print once, instead of repeatedly outputting like shown below

DEBUG 07-11 16:11:47 [deep_gemm_moe.py:46] DeepGemm disabled: deep_gemm not available.
DEBUG 07-11 16:11:47 [deep_gemm_moe.py:46] DeepGemm disabled: deep_gemm not available.
DEBUG 07-11 16:11:47 [deep_gemm_moe.py:46] DeepGemm disabled: deep_gemm not available.
DEBUG 07-11 16:11:47 [deep_gemm_moe.py:46] DeepGemm disabled: deep_gemm not available.
DEBUG 07-11 16:11:47 [deep_gemm_moe.py:46] DeepGemm disabled: deep_gemm not available.
DEBUG 07-11 16:11:47 [deep_gemm_moe.py:46] DeepGemm disabled: deep_gemm not available.
DEBUG 07-11 16:11:47 [deep_gemm_moe.py:46] DeepGemm disabled: deep_gemm not available.
DEBUG 07-11 16:11:47 [deep_gemm_moe.py:46] DeepGemm disabled: deep_gemm not available.
DEBUG 07-11 16:11:47 [deep_gemm_moe.py:46] DeepGemm disabled: deep_gemm not available.
DEBUG 07-11 16:11:47 [deep_gemm_moe.py:46] DeepGemm disabled: deep_gemm not available.
DEBUG 07-11 16:11:47 [deep_gemm_moe.py:46] DeepGemm disabled: deep_gemm not available.
DEBUG 07-11 16:11:47 [deep_gemm_moe.py:46] DeepGemm disabled: deep_gemm not available.
DEBUG 07-11 16:11:47 [deep_gemm_moe.py:46] DeepGemm disabled: deep_gemm not available.
DEBUG 07-11 16:11:47 [deep_gemm_moe.py:46] DeepGemm disabled: deep_gemm not available.
DEBUG 07-11 16:11:47 [deep_gemm_moe.py:46] DeepGemm disabled: deep_gemm not available.
DEBUG 07-11 16:11:47 [deep_gemm_moe.py:46] DeepGemm disabled: deep_gemm not available.
DEBUG 07-11 16:11:47 [deep_gemm_moe.py:46] DeepGemm disabled: deep_gemm not available.
DEBUG 07-11 16:11:47 [deep_gemm_moe.py:46] DeepGemm disabled: deep_gemm not available.
DEBUG 07-11 16:11:47 [deep_gemm_moe.py:46] DeepGemm disabled: deep_gemm not available.
DEBUG 07-11 16:11:47 [deep_gemm_moe.py:46] DeepGemm disabled: deep_gemm not available.
DEBUG 07-11 16:11:47 [deep_gemm_moe.py:46] DeepGemm disabled: deep_gemm not available.
DEBUG 07-11 16:11:47 [deep_gemm_moe.py:46] DeepGemm disabled: deep_gemm not available.
DEBUG 07-11 16:11:47 [deep_gemm_moe.py:46] DeepGemm disabled: deep_gemm not available.
DEBUG 07-11 16:11:47 [deep_gemm_moe.py:46] DeepGemm disabled: deep_gemm not available.
DEBUG 07-11 16:11:47 [deep_gemm_moe.py:46] DeepGemm disabled: deep_gemm not available.

Test Plan

Test Result

(Optional) Documentation Update

Signed-off-by: Jee Jee Li <[email protected]>
@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @jeejeelee, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an issue where DeepGemm-related debug messages were being repeatedly printed, leading to excessive log output. The change ensures that these specific debug messages are now printed only once, significantly reducing log noise and improving the clarity of the console output.

Highlights

  • Logging Improvement: I've updated the _valid_deep_gemm function in vllm/model_executor/layers/fused_moe/deep_gemm_moe.py to use logger.debug_once instead of logger.debug. This change specifically applies to messages indicating that DeepGemm is disabled due to unavailability or unaligned problem sizes.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@jeejeelee jeejeelee changed the title [Misc] Restrict DeepGemm's log output [Misc] Restrict deep_gemm's log output Jul 11, 2025
Signed-off-by: Jee Jee Li <[email protected]>
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request effectively addresses the issue of repeated log messages by switching to logger.debug_once. This is a good change to improve log clarity.

I've added one suggestion to make one of the debug messages more informative by including the specific problem size that causes the issue. This will help in debugging scenarios with varying input shapes.

Overall, the change is in the right direction.

@jeejeelee jeejeelee requested a review from mgoin July 11, 2025 16:43
Copy link
Member

@mgoin mgoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks, cc @yewentao256

Copy link
Member

@yewentao256 yewentao256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@mgoin mgoin enabled auto-merge (squash) July 11, 2025 19:55
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Jul 11, 2025
@simon-mo simon-mo disabled auto-merge July 12, 2025 03:50
@simon-mo simon-mo merged commit 44d02f5 into vllm-project:main Jul 12, 2025
74 of 76 checks passed
@jeejeelee jeejeelee deleted the deep-moe-log branch July 12, 2025 04:36
x22x22 pushed a commit to x22x22/vllm that referenced this pull request Aug 5, 2025
Pradyun92 pushed a commit to Pradyun92/vllm that referenced this pull request Aug 6, 2025
npanpaliya pushed a commit to odh-on-pz/vllm-upstream that referenced this pull request Aug 6, 2025
jinzhen-lin pushed a commit to jinzhen-lin/vllm that referenced this pull request Aug 9, 2025
paulpak58 pushed a commit to paulpak58/vllm that referenced this pull request Aug 13, 2025
diegocastanibm pushed a commit to diegocastanibm/vllm that referenced this pull request Aug 15, 2025
epwalsh pushed a commit to epwalsh/vllm that referenced this pull request Aug 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants