-
-
Notifications
You must be signed in to change notification settings - Fork 11.3k
[Refactor] Change the way of import triton #20774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Refactor] Change the way of import triton #20774
Conversation
Signed-off-by: yewentao256 <[email protected]>
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @yewentao256, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request refactors how Triton and Triton.language (tl) modules are imported throughout the codebase. The change ensures that all Triton-related imports conform to a centralized vllm.triton_utils module, aligning with project-specific import guidelines and preventing pre-commit validation failures.
Highlights
- Import Standardization: Standardized the way Triton and Triton.language (tl) modules are imported across multiple files. This change ensures all Triton-related imports now originate from
vllm.triton_utils, aligning with the project's enforced import style. - Pre-commit Compliance: Addressed potential pre-commit errors by modifying import statements to conform to the
ALLOWED_LINESdefined invllm/tools/check_triton_import.py, which restricts directtritonortriton.languageimports.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request refactors the way Triton is imported across several files, centralizing the import logic into vllm.triton_utils. This is a good practice that improves maintainability and helps in handling cases where Triton is not available. The changes are consistent and correct. I have reviewed the modifications and found no issues to report at the requested severity levels (medium, high, critical).
Signed-off-by: yewentao256 <[email protected]> Signed-off-by: x22x22 <[email protected]>
Signed-off-by: yewentao256 <[email protected]>
Signed-off-by: yewentao256 <[email protected]>
Signed-off-by: yewentao256 <[email protected]> Signed-off-by: Jinzhen Lin <[email protected]>
Signed-off-by: yewentao256 <[email protected]> Signed-off-by: Paul Pak <[email protected]>
Signed-off-by: yewentao256 <[email protected]> Signed-off-by: Diego-Castan <[email protected]>
Signed-off-by: yewentao256 <[email protected]>
Purpose
As shown in
vllm/tools/check_triton_import.py, onlyare allowed, this pr fixes the possible pre-commit error