-
-
Notifications
You must be signed in to change notification settings - Fork 12.5k
Gemma3n (Text-only) #20134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ywang96
merged 14 commits into
vllm-project:main
from
robertgshaw2-redhat:gemma-3n-upstream
Jun 27, 2025
+870
−0
Merged
Gemma3n (Text-only) #20134
Changes from 11 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
16187fe
added model
robertgshaw2-redhat 4b02f7d
address bot comments
robertgshaw2-redhat ed2e3f0
update version
robertgshaw2-redhat 7bc8f13
address comment
robertgshaw2-redhat c3b3f16
updated
robertgshaw2-redhat 1bf7eee
add to registry
aea70dd
text-only
f914b01
add to registry
55360b0
update doc
add8f13
remove
d31324a
remove pp
5ec4473
typo
8df9d1a
update
fe11f36
add note
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually wait. We should not force update transformers yet, it will break Qwen2.5-Omni. cc @Isotr0py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is that confirmed? If so we can user users to upgrade transformers manually.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#19833
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From the look of it, it seems that the blast radius is more than just on Qwen2.5-Omni. See vllm-project/vllm-ascend#1470, so I'll update this PR accordingly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a big refactoring at config and processor in Transformers v4.53, we need to ask users to upgrade transformers manually temporarily before we add compatibility for it.