[CI] Sync test dependency with test.in for torch nightly#19632
[CI] Sync test dependency with test.in for torch nightly#19632vllm-bot merged 23 commits intovllm-project:mainfrom
Conversation
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Summary of Changes
Hello @yangw-dev, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request streamlines test dependency management by introducing an automated process to separate torch and mamba-related requirements from the core test dependencies. A new script handles the filtering and file generation, and a pre-commit hook ensures these files stay synchronized with the primary dependency list (requirements/test.in).
Highlights
- Dependency Management Automation: I've introduced a new Python script (
tools/generate_nightly_torch_test.py) designed to automate the management of test dependencies by filtering the mainrequirements/test.infile. - Dependency Separation: Torch and mamba-specific test dependencies are now separated from the main list and placed into a new file (
torch_nightly_test.txt). The remaining dependencies fromtest.inare written torequirements/nightly_torch_test.txt. - Pre-commit Integration: The new dependency generation script has been integrated into the pre-commit hooks. This ensures that
requirements/nightly_torch_test.txtandtorch_nightly_test.txtare automatically updated wheneverrequirements/test.inis changed. - Dependency Updates: I've updated and refined the list of test dependencies within
requirements/test.inand the resulting generated files, including adding and removing several packages and updating version specifiers.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configureGemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This PR introduces a new system for managing PyTorch dependencies for nightly tests, using tools/generate_nightly_torch_test.py to separate packages from requirements/test.in into torch_nightly_test.txt and requirements/nightly_torch_test.txt. Please update the PR title to accurately reflect the changes (e.g., "Refactor nightly test dependencies for PyTorch"), and fill out the PR description with the purpose of these changes, any testing performed, and results. There's a removal of vector_quantize_pytorch from requirements/test.in; confirm if this is intended.
Signed-off-by: Yida Wu <yidawu@alumni.cmu.edu> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Co-authored-by: Cyrus Leung <cyrus.tl.leung@gmail.com> Signed-off-by: Yang Wang <elainewy@meta.com>
…#19624) Signed-off-by: Nick Hill <nhill@redhat.com> Signed-off-by: Yang Wang <elainewy@meta.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Yang Wang <elainewy@meta.com>
e58722c to
e649cd6
Compare
houseroad
left a comment
There was a problem hiding this comment.
Could you fill the PR description with some details? :-)
0612c36 to
b245e6c
Compare
Head branch was pushed to by a user without write access
7196a9d to
d63c6ac
Compare
Description
test dependency in nightly_torch_test.txt is in sync with test.txt
Why not generate the nightly_torch_test.txt directly from modified test.in ?
Unfortunately, even remove the torch dependencies from test.in, pip-compile still aim to install torch stable version.
This is a workaround.
Details
What happen if override happen?
the test fails
Most cases, it means the package needs to build from source with torch nightly, a short-term solution is to ask user to put the packge in the keywords list in pre-commit script
tools/generate_nightly_torch_test.py, we comment the guidance in the added test if the mismatch happenstools/generate_nightly_torch_test.py
Currently four dependency are removed from test.in
["torch", "torchaudio", "torchvision", "mamba_ssm"]
the mamba_ssm seems causes build wheel failure, more investigation is needed, for now it's considered safe since no torch_nightly tests are dependent on it.