[Misc] Modularize CLI Argument Parsing in Benchmark Scripts#19593
[Misc] Modularize CLI Argument Parsing in Benchmark Scripts#19593houseroad merged 1 commit intovllm-project:mainfrom
Conversation
Signed-off-by: reidliu41 <reid201711@gmail.com>
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
houseroad
left a comment
There was a problem hiding this comment.
Better to run the benchmark scripts with the changes to ensure correctness.
|
thanks for your remind, i think it should work. |
|
hi team, @DarkLight1337 can you help to set |
@reidliu41 Sorry I forgot to put on the ready label - added it just now! |
|
seems all passed, is it able to merge? |
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.Purpose
Test Plan
Test Result
(Optional) Documentation Update