[Misc] Add packages for benchmark as extra dependency#19089
[Misc] Add packages for benchmark as extra dependency#19089vllm-bot merged 4 commits intovllm-project:mainfrom
Conversation
Signed-off-by: Isotr0py <2037008807@qq.com>
Signed-off-by: Isotr0py <2037008807@qq.com>
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
Signed-off-by: Isotr0py <2037008807@qq.com>
|
Thanks! Just to clarify intent, I think datasets.py should only lazy import packages that aren't already in vllm so adding new datasets does not affect default user flows/deps. I've done this ad-hoc in a few places, so it would be good to standardize how we do this, like you propose here |
DarkLight1337
left a comment
There was a problem hiding this comment.
LGTM subject to @mgoin 's comments
Signed-off-by: Isotr0py <2037008807@qq.com>
…9089) Signed-off-by: Isotr0py <2037008807@qq.com>
FIX #19078
pandasanddatasetspip install vllm[bench]