Skip to content

[Misc] Add packages for benchmark as extra dependency#19089

Merged
vllm-bot merged 4 commits intovllm-project:mainfrom
Isotr0py:benchmark-cli
Jun 4, 2025
Merged

[Misc] Add packages for benchmark as extra dependency#19089
vllm-bot merged 4 commits intovllm-project:mainfrom
Isotr0py:benchmark-cli

Conversation

@Isotr0py
Copy link
Copy Markdown
Member

@Isotr0py Isotr0py commented Jun 3, 2025

FIX #19078

  • To run benchmark cli, we need to install extra packages like pandas and datasets
  • This PR adds them as extra dependency, so users can install them through pip install vllm[bench]

Isotr0py added 2 commits June 3, 2025 15:15
Signed-off-by: Isotr0py <2037008807@qq.com>
Signed-off-by: Isotr0py <2037008807@qq.com>
@Isotr0py Isotr0py requested a review from hmellor as a code owner June 3, 2025 13:29
@mergify mergify bot added documentation Improvements or additions to documentation ci/build frontend labels Jun 3, 2025
@Isotr0py Isotr0py requested a review from DarkLight1337 June 3, 2025 13:31
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jun 3, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

Signed-off-by: Isotr0py <2037008807@qq.com>
@mgoin
Copy link
Copy Markdown
Member

mgoin commented Jun 4, 2025

Thanks! Just to clarify intent, I think datasets.py should only lazy import packages that aren't already in vllm so adding new datasets does not affect default user flows/deps. I've done this ad-hoc in a few places, so it would be good to standardize how we do this, like you propose here

Copy link
Copy Markdown
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM subject to @mgoin 's comments

Signed-off-by: Isotr0py <2037008807@qq.com>
@Isotr0py Isotr0py enabled auto-merge (squash) June 4, 2025 07:09
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Jun 4, 2025
@vllm-bot vllm-bot merged commit 8711bc5 into vllm-project:main Jun 4, 2025
93 of 97 checks passed
@Isotr0py Isotr0py deleted the benchmark-cli branch July 13, 2025 04:05
sducouedic pushed a commit to sducouedic/vllm that referenced this pull request Oct 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/build documentation Improvements or additions to documentation frontend ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: ModuleNotFoundError: No module named 'pandas'

4 participants