Skip to content

Conversation

@lengrongfu
Copy link
Contributor

@lengrongfu lengrongfu commented May 31, 2025

FIX #18986

because ipv6 construct tcp url format is not ipv4, so need use ipv6 url string tcp://[2605:340:cd51:a00:2a6:1aa4:9970:acec]:53280 to connect.

@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

Copy link
Member

@njhill njhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lengrongfu, LGTM

@lengrongfu lengrongfu marked this pull request as ready for review May 31, 2025 15:17
@njhill njhill changed the title fix data parallel construct ipv6 url addres [BugFix] fix data parallel construct ipv6 url addres May 31, 2025
@njhill njhill added the ready ONLY add when PR is ready to merge/full CI is needed label May 31, 2025
@DarkLight1337 DarkLight1337 merged commit aa54a7b into vllm-project:main Jun 1, 2025
79 checks passed
amitm02 pushed a commit to amitm02/vllm that referenced this pull request Jun 1, 2025
amitm02 pushed a commit to amitm02/vllm that referenced this pull request Jun 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Multi-node data parallel cannot recognize IPv6 host address

3 participants