Skip to content

[LoRA] Support dynamically initialize packed_modules_mapping for VLM with arbitrary components#18987

Merged
Isotr0py merged 7 commits intovllm-project:mainfrom
Isotr0py:arb-lora
Jun 1, 2025
Merged

[LoRA] Support dynamically initialize packed_modules_mapping for VLM with arbitrary components#18987
Isotr0py merged 7 commits intovllm-project:mainfrom
Isotr0py:arb-lora

Conversation

@Isotr0py
Copy link
Copy Markdown
Member

@Isotr0py Isotr0py commented May 31, 2025

  • Some VLM series like InternVL and Ovis can have various languages backbone and ViTs, which causes a complicated packed_modules_mapping for LoRA and BNB support.
  • This PR allows initializing packed_modules_mapping from VLM's components dynamically, so we don't need to copy all packed_modules_mapping from each component variant.

Isotr0py added 3 commits May 31, 2025 11:34
Signed-off-by: isotr0py <2037008807@qq.com>
Signed-off-by: isotr0py <2037008807@qq.com>
Signed-off-by: Isotr0py <2037008807@qq.com>
@github-actions
Copy link
Copy Markdown

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

Isotr0py added 4 commits May 31, 2025 20:03
Signed-off-by: Isotr0py <2037008807@qq.com>
Signed-off-by: Isotr0py <2037008807@qq.com>
Signed-off-by: Isotr0py <2037008807@qq.com>
Signed-off-by: Isotr0py <2037008807@qq.com>
@Isotr0py Isotr0py marked this pull request as ready for review May 31, 2025 13:42
@Isotr0py Isotr0py requested a review from jeejeelee as a code owner May 31, 2025 13:42
@jeejeelee jeejeelee added the ready ONLY add when PR is ready to merge/full CI is needed label May 31, 2025
@Isotr0py Isotr0py merged commit a35ca76 into vllm-project:main Jun 1, 2025
81 checks passed
@Isotr0py Isotr0py deleted the arb-lora branch June 1, 2025 03:07
amitm02 pushed a commit to amitm02/vllm that referenced this pull request Jun 1, 2025
…M with arbitrary components (vllm-project#18987)

Signed-off-by: isotr0py <2037008807@qq.com>
Signed-off-by: Isotr0py <2037008807@qq.com>
Signed-off-by: amit <amit.man@gmail.com>
amitm02 pushed a commit to amitm02/vllm that referenced this pull request Jun 1, 2025
…M with arbitrary components (vllm-project#18987)

Signed-off-by: isotr0py <2037008807@qq.com>
Signed-off-by: Isotr0py <2037008807@qq.com>
Signed-off-by: amit <amit.man@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants