[Misc] add return token strs for tokenize#18941
[Misc] add return token strs for tokenize#18941DarkLight1337 merged 2 commits intovllm-project:mainfrom
Conversation
Signed-off-by: reidliu41 <reid201711@gmail.com>
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
|
@DarkLight1337 hi, could you please help to take a look this if you have time? thanks |
|
Can you add a test? |
Signed-off-by: reidliu41 <reid201711@gmail.com>
DarkLight1337
left a comment
There was a problem hiding this comment.
Thanks for adding this!
Signed-off-by: reidliu41 <reid201711@gmail.com> Co-authored-by: reidliu41 <reid201711@gmail.com> Signed-off-by: amit <amit.man@gmail.com>
Signed-off-by: reidliu41 <reid201711@gmail.com> Co-authored-by: reidliu41 <reid201711@gmail.com> Signed-off-by: amit <amit.man@gmail.com>
FIX #18928 (link existing issues this PR will resolve)