[Core] Improve Tensor serialisation#18774
Conversation
Signed-off-by: Lukas Geiger <lukas.geiger94@gmail.com>
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
|
I'm going to revert this since it broke some tests: #18857. We can look into the reason and open another PR as needed. |
|
Oh so sorry, about that. I can have a look at it in a bit |
|
#18860 Should fix it |
Signed-off-by: Lukas Geiger <lukas.geiger94@gmail.com> Signed-off-by: amit <amit.man@gmail.com>
This improves v1 tensor serialisation by directly relying on
torch.frombufferwhich removes the need for an temporary numpy array which is a bit easier to read.Here's a small micro benchmark to verify that this is also faster:
main:
This PR: