[Bugfix][Failing Test] Fix test_vllm_port.py#18618
[Bugfix][Failing Test] Fix test_vllm_port.py#18618DarkLight1337 merged 1 commit intovllm-project:mainfrom
Conversation
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
b5df503 to
95d88d1
Compare
|
This pull request has merge conflicts that must be resolved before it can be |
The urllib.parse.urlparse() function itself does not raise an exception during the parsing of a URL. However, certain attributes of the returned ParseResult object (e.g., .port) may raise a ValueError when accessed if they contain invalid values. Issue introduced in vllm-project#18209 FIX: vllm-project#18617 Signed-off-by: rabi <ramishra@redhat.com>
|
@DarkLight1337 Hey! can this be merged to fix the test or you're still looking for some specific input from others? |
|
cc @russellb |
DarkLight1337
left a comment
There was a problem hiding this comment.
Well the tests pass so let's just merge this
Signed-off-by: rabi <ramishra@redhat.com> Signed-off-by: amit <amit.man@gmail.com>
Signed-off-by: rabi <ramishra@redhat.com> Signed-off-by: amit <amit.man@gmail.com>
The urllib.parse.urlparse() function itself does not raise an exception during the parsing of a URL. However, certain attributes of the returned ParseResult object (e.g., .port) may raise a ValueError when accessed if they contain invalid values.
Issue introduced in #18209
FIX: #18617