Skip to content

[Bugfix][Failing Test] Fix test_vllm_port.py#18618

Merged
DarkLight1337 merged 1 commit intovllm-project:mainfrom
rabi:18617
May 30, 2025
Merged

[Bugfix][Failing Test] Fix test_vllm_port.py#18618
DarkLight1337 merged 1 commit intovllm-project:mainfrom
rabi:18617

Conversation

@rabi
Copy link
Contributor

@rabi rabi commented May 23, 2025

The urllib.parse.urlparse() function itself does not raise an exception during the parsing of a URL. However, certain attributes of the returned ParseResult object (e.g., .port) may raise a ValueError when accessed if they contain invalid values.

Issue introduced in #18209

FIX: #18617

@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@DarkLight1337 DarkLight1337 requested a review from russellb May 23, 2025 14:26
@rabi rabi force-pushed the 18617 branch 2 times, most recently from b5df503 to 95d88d1 Compare May 23, 2025 14:30
@DarkLight1337 DarkLight1337 added the ready ONLY add when PR is ready to merge/full CI is needed label May 23, 2025
@mergify
Copy link

mergify bot commented May 24, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @rabi.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label May 24, 2025
The urllib.parse.urlparse() function itself does not raise
an exception during the parsing of a URL. However, certain
attributes of the returned ParseResult object (e.g., .port)
may raise a ValueError when accessed if they contain invalid
values.

Issue introduced in vllm-project#18209

FIX: vllm-project#18617
Signed-off-by: rabi <ramishra@redhat.com>
@rabi
Copy link
Contributor Author

rabi commented May 27, 2025

@DarkLight1337 Hey! can this be merged to fix the test or you're still looking for some specific input from others?

@DarkLight1337
Copy link
Member

cc @russellb

Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well the tests pass so let's just merge this

@DarkLight1337 DarkLight1337 merged commit 5f1d0c8 into vllm-project:main May 30, 2025
93 checks passed
amitm02 pushed a commit to amitm02/vllm that referenced this pull request Jun 1, 2025
Signed-off-by: rabi <ramishra@redhat.com>
Signed-off-by: amit <amit.man@gmail.com>
amitm02 pushed a commit to amitm02/vllm that referenced this pull request Jun 1, 2025
Signed-off-by: rabi <ramishra@redhat.com>
Signed-off-by: amit <amit.man@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/build ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: test_vllm_port.py::test_get_vllm_port_uri fails with AssertionError: Regex pattern did not match

2 participants