Fix copy-paste error in phi4mm image processing#18315
Fix copy-paste error in phi4mm image processing#18315vllm-bot merged 1 commit intovllm-project:mainfrom
Conversation
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
Signed-off-by: Lifu Huang <lifu.hlf@gmail.com>
Signed-off-by: Lifu Huang <lifu.hlf@gmail.com> Signed-off-by: Yuqi Zhang <yuqizhang@google.com>
The current Phi4mm implementation only supports pixels as input but not embeddings.
The existing embedding handling logic code seems to mistakenly copied from other models -- it's referring to modules not existing in phi4mm
self.visual(in phi4mm, the encoding module isvision_encoder)