Skip to content

fix warning in eagle.py#18288

Closed
RuixiangMa wants to merge 1 commit intovllm-project:mainfrom
RuixiangMa:fixwarning
Closed

fix warning in eagle.py#18288
RuixiangMa wants to merge 1 commit intovllm-project:mainfrom
RuixiangMa:fixwarning

Conversation

@RuixiangMa
Copy link
Contributor

@RuixiangMa RuixiangMa commented May 17, 2025

vllm/examples/offline_inference/eagle.py:132: DeprecationWarning: The keyword arguments {'prompt_token_ids'} are deprecated and will be removed in a future update. Please use the 'prompts' parameter instead.

@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the documentation Improvements or additions to documentation label May 17, 2025
@RuixiangMa RuixiangMa changed the title fix warning in examples eagle.py fix warning in eagle.py May 17, 2025

outputs = llm.generate(prompt_token_ids=prompt_ids,
sampling_params=sampling_params)
outputs = llm.generate(prompts=prompts, sampling_params=sampling_params)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like you simply removed the alternative input. We still support prompt token ID inputs, but it has to be inside a dictionary passed to prompts. You can check the type annotations for more information.

@DarkLight1337
Copy link
Member

Closing as superseded by #18800

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation speculative-decoding

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants