[Bugfix] fix rotary embedding test for _get_padded_tensor_shape#18227
[Bugfix] fix rotary embedding test for _get_padded_tensor_shape#18227luccafong wants to merge 2 commits intovllm-project:mainfrom
Conversation
Signed-off-by: Lucia Fang <fanglu@fb.com>
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
Signed-off-by: Lucia Fang <fanglu@fb.com>
|
@luccafong has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
There was a problem hiding this comment.
Thanks for the PR! I think this might be cleaners; also ensures we test with padding: #18229
Fix test failure below for test_rotary_embdding on padded tensor shape:
pytest -v tests/ke rnels/core/test_pos_encoding.py -k test_rotary_embedding