Skip to content

[Misc] Avoid cuda graph log when sizes still match#18202

Merged
vllm-bot merged 1 commit intovllm-project:mainfrom
NickLucche:misc
May 15, 2025
Merged

[Misc] Avoid cuda graph log when sizes still match#18202
vllm-bot merged 1 commit intovllm-project:mainfrom
NickLucche:misc

Conversation

@NickLucche
Copy link
Collaborator

@NickLucche NickLucche commented May 15, 2025

Tiniest improvement in log clarity.
I think printing this log line when cuda graph sizes are not actually overridden it's just clutter

# pre
[__init__.py:248] Automatically detected platform tpu.
[config.py:3955] cudagraph sizes specified by model runner [1, 2, 4, 8, 16, 24, 32, 40, 48, 56, 64, 72, 80, 88, 96, 104, 112, 120, 128] is overridden by config [128, 1, 2, 4, 8, 16, 24, 32, 40, 48, 56, 64, 72, 80, 88, 96, 104, 112, 120]
[core.py:427] Waiting for init message from front-end.

# post
[__init__.py:248] Automatically detected platform tpu.
[core.py:427] Waiting for init message from front-end.

Signed-off-by: NickLucche <nlucches@redhat.com>
@NickLucche NickLucche changed the title [MISC] Avoid cuda graph log when sizes still match [Misc] Avoid cuda graph log when sizes still match May 15, 2025
@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@DarkLight1337 DarkLight1337 requested a review from youkaichao May 15, 2025 13:39
@mgoin mgoin added the ready ONLY add when PR is ready to merge/full CI is needed label May 15, 2025
@mgoin
Copy link
Member

mgoin commented May 15, 2025

Makes sense why this was always triggering, thanks!

@vllm-bot vllm-bot merged commit e3f3aee into vllm-project:main May 15, 2025
66 of 69 checks passed
zzzyq pushed a commit to zzzyq/vllm that referenced this pull request May 24, 2025
Signed-off-by: NickLucche <nlucches@redhat.com>
Signed-off-by: Yuqi Zhang <yuqizhang@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants