Skip to content

[V1][Spec Decoding] Log accumulated metrics after system goes idle#17913

Merged
WoosukKwon merged 1 commit intovllm-project:mainfrom
markmc:metrics-v1-spec-decoding-idle
May 10, 2025
Merged

[V1][Spec Decoding] Log accumulated metrics after system goes idle#17913
WoosukKwon merged 1 commit intovllm-project:mainfrom
markmc:metrics-v1-spec-decoding-idle

Conversation

@markmc
Copy link
Member

@markmc markmc commented May 9, 2025 •
edited by github-actions bot
Loading

Sending a single request wasn't causing any metrics to be logged.

@markmc
[V1][Spec Decoding] Log accumulated metrics after system goes idle
8eccf2f 
Sending a single request wasn't causing any metrics to be logged.

Signed-off-by: Mark McLoughlin <markmc@redhat.com>
@github-actions
Copy link

github-actions bot commented May 9, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@markmc markmc added speculative-decoding v1 ready ONLY add when PR is ready to merge/full CI is needed labels May 9, 2025
WoosukKwon
WoosukKwon approved these changes May 10, 2025
View reviewed changes
Copy link
Collaborator

@WoosukKwon WoosukKwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the fix

@WoosukKwon WoosukKwon merged commit 7042cc9 into vllm-project:main May 10, 2025
70 checks passed
princepride pushed a commit to princepride/vllm that referenced this pull request May 10, 2025
@markmc @princepride
[V1][Spec Decoding] Log accumulated metrics after system goes idle (v…
560c70e 
…llm-project#17913)

Signed-off-by: Mark McLoughlin <markmc@redhat.com>
Signed-off-by: 汪志鹏 <wangzhipeng628@gmail.com>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@markmc
[V1][Spec Decoding] Log accumulated metrics after system goes idle (v…
e1a3a75 
…llm-project#17913)

Signed-off-by: Mark McLoughlin <markmc@redhat.com>
Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
mawong-amd pushed a commit to ROCm/vllm that referenced this pull request May 14, 2025
@markmc @mawong-amd
[V1][Spec Decoding] Log accumulated metrics after system goes idle (v…
3ef75b0 
…llm-project#17913)

Signed-off-by: Mark McLoughlin <markmc@redhat.com>
zzzyq pushed a commit to zzzyq/vllm that referenced this pull request May 24, 2025
@markmc
[V1][Spec Decoding] Log accumulated metrics after system goes idle (v…
970ffcb 
…llm-project#17913)

Signed-off-by: Mark McLoughlin <markmc@redhat.com>
Signed-off-by: Yuqi Zhang <yuqizhang@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@WoosukKwon WoosukKwon WoosukKwon approved these changes

@robertgshaw2-redhat robertgshaw2-redhat Awaiting requested review from robertgshaw2-redhat

@njhill njhill Awaiting requested review from njhill

@ywang96 ywang96 Awaiting requested review from ywang96

@comaniac comaniac Awaiting requested review from comaniac

@alexm-redhat alexm-redhat Awaiting requested review from alexm-redhat

Assignees

No one assigned

Labels

ready ONLY add when PR is ready to merge/full CI is needed speculative-decoding v1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@markmc @WoosukKwon