Skip to content

[Bugfix] Fix Video IO error for short video#17791

Merged
DarkLight1337 merged 5 commits intovllm-project:mainfrom
Isotr0py:fix-video-io
May 7, 2025
Merged

[Bugfix] Fix Video IO error for short video#17791
DarkLight1337 merged 5 commits intovllm-project:mainfrom
Isotr0py:fix-video-io

Conversation

@Isotr0py
Copy link
Member

@Isotr0py Isotr0py commented May 7, 2025

FIX #17775 (link existing issues this PR will resolve)

  • Fix missing num_frames update for OpenCV video IO backend
  • Add video tests for media IO.

Isotr0py added 3 commits May 7, 2025 20:11
Signed-off-by: Isotr0py <2037008807@qq.com>
Signed-off-by: Isotr0py <2037008807@qq.com>
Signed-off-by: Isotr0py <2037008807@qq.com>
@github-actions
Copy link

github-actions bot commented May 7, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the multi-modality Related to multi-modality (#4194) label May 7, 2025
@DarkLight1337 DarkLight1337 enabled auto-merge (squash) May 7, 2025 12:31
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label May 7, 2025
Isotr0py added 2 commits May 7, 2025 20:33
Signed-off-by: Isotr0py <2037008807@qq.com>
Signed-off-by: Isotr0py <2037008807@qq.com>
@DarkLight1337 DarkLight1337 merged commit be8ff88 into vllm-project:main May 7, 2025
49 checks passed
@Isotr0py Isotr0py deleted the fix-video-io branch May 7, 2025 15:38
princepride pushed a commit to princepride/vllm that referenced this pull request May 10, 2025
Signed-off-by: Isotr0py <2037008807@qq.com>
Signed-off-by: 汪志鹏 <wangzhipeng628@gmail.com>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
Signed-off-by: Isotr0py <2037008807@qq.com>
Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
mawong-amd pushed a commit to ROCm/vllm that referenced this pull request May 14, 2025
Signed-off-by: Isotr0py <2037008807@qq.com>
zzzyq pushed a commit to zzzyq/vllm that referenced this pull request May 24, 2025
Signed-off-by: Isotr0py <2037008807@qq.com>
Signed-off-by: Yuqi Zhang <yuqizhang@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

multi-modality Related to multi-modality (#4194) ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: qwen2.5vl internal server error when processing videos from split_video_ffmpeg after realease 0.8.3

2 participants