Skip to content

Fix and simplify deprecated=True CLI kwarg#17781

Merged
hmellor merged 3 commits intovllm-project:mainfrom
hmellor:fix-deprecated-cli-kwarg
May 7, 2025
Merged

Fix and simplify deprecated=True CLI kwarg#17781
hmellor merged 3 commits intovllm-project:mainfrom
hmellor:fix-deprecated-cli-kwarg

Conversation

@hmellor
Copy link
Member

@hmellor hmellor commented May 7, 2025

Fixes error seen on main

@hmellor
Fix and simplify deprecated=True CLI kwarg
54246d6 
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
@github-actions
Copy link

github-actions bot commented May 7, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

DarkLight1337
DarkLight1337 approved these changes May 7, 2025
View reviewed changes
Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing, see if tests pass now

@DarkLight1337 DarkLight1337 added the ready ONLY add when PR is ready to merge/full CI is needed label May 7, 2025
@hmellor
add_cli_args is expecting a parser not a group
3dd073c 
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
@mergify mergify bot added the documentation Improvements or additions to documentation label May 7, 2025
@hmellor hmellor added this to the v0.9.0 milestone May 7, 2025
@hmellor
Check if namespace actually has action.dest
ed376b9 
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
@hmellor hmellor mentioned this pull request May 7, 2025
Merged
@hmellor hmellor merged commit 646a31e into vllm-project:main May 7, 2025
54 checks passed
@hmellor hmellor deleted the fix-deprecated-cli-kwarg branch May 7, 2025 15:51
princepride pushed a commit to princepride/vllm that referenced this pull request May 10, 2025
@hmellor @princepride
Fix and simplify deprecated=True CLI kwarg (vllm-project#17781)
981767c 
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: 汪志鹏 <wangzhipeng628@gmail.com>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@hmellor
Fix and simplify deprecated=True CLI kwarg (vllm-project#17781)
0865de7 
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
mawong-amd pushed a commit to ROCm/vllm that referenced this pull request May 14, 2025
@hmellor @mawong-amd
Fix and simplify deprecated=True CLI kwarg (vllm-project#17781)
064984e 
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
zzzyq pushed a commit to zzzyq/vllm that referenced this pull request May 24, 2025
@hmellor
Fix and simplify deprecated=True CLI kwarg (vllm-project#17781)
d74ef22 
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Yuqi Zhang <yuqizhang@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeejeelee jeejeelee jeejeelee approved these changes

@DarkLight1337 DarkLight1337 DarkLight1337 approved these changes

Assignees

No one assigned

Labels

documentation Improvements or additions to documentation ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Milestone

v0.9.0

Development

Successfully merging this pull request may close these issues.

3 participants

@hmellor @jeejeelee @DarkLight1337