[Misc] Clean up test docstrings and names#17521
Conversation
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
DarkLight1337
added
the
ready
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
| @@ -1,9 +1,4 @@ | |||
| # SPDX-License-Identifier: Apache-2.0 | |||
| """Compare the outputs of HF and vLLM when using greedy sampling. | |||
There was a problem hiding this comment.
I think these docstrings are pretty useless and run the risk of the command no longer matching the file name, so I removed them.
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk> Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk> Signed-off-by: Yuqi Zhang <yuqizhang@google.com>
3 participants
Follow-up to #17459 to rename some more tests and clean up docstrings.