Skip to content

Transformers backend tweaks#17365

Merged
vllm-bot merged 2 commits intovllm-project:mainfrom
hmellor:transformers-backend-tweak
Apr 29, 2025
Merged

Transformers backend tweaks#17365
vllm-bot merged 2 commits intovllm-project:mainfrom
hmellor:transformers-backend-tweak

Conversation

@hmellor
Copy link
Member

@hmellor hmellor commented Apr 29, 2025

Follow ups from #16868 (review):

  • Remove meta_to_empty which is not needed anymore
  • Add a warning if a custom model has a buffer which is a direct child of the base model

hmellor added 2 commits April 29, 2025 10:38
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@hmellor hmellor requested a review from Isotr0py April 29, 2025 08:42
@hmellor hmellor changed the title Transformers-backend-tweak Transformers backend tweaks Apr 29, 2025
@Isotr0py Isotr0py enabled auto-merge (squash) April 29, 2025 14:19
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Apr 29, 2025
@vllm-bot vllm-bot merged commit 900edfa into vllm-project:main Apr 29, 2025
61 of 65 checks passed
@hmellor hmellor deleted the transformers-backend-tweak branch April 29, 2025 16:45
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
radeksm pushed a commit to radeksm/vllm that referenced this pull request May 2, 2025
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
zzzyq pushed a commit to zzzyq/vllm that referenced this pull request May 24, 2025
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Yuqi Zhang <yuqizhang@google.com>
@hmellor hmellor moved this to Done in Transformers backend Sep 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants