[Test] Attempt all TPU V1 tests, even if some of them fail.#17334
[Test] Attempt all TPU V1 tests, even if some of them fail.#17334robertgshaw2-redhat merged 6 commits intovllm-project:mainfrom
Conversation
Signed-off-by: Yarong Mu <ymu@google.com>
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
yaochengji
left a comment
yaochengji
left a comment
There was a problem hiding this comment.
LGTM, thanks for the enhancement!
yaochengji
added
tpu
|
This pull request has merge conflicts that must be resolved before it can be |
Signed-off-by: Yarong Mu <ymu@google.com>
Signed-off-by: Yarong Mu <ymu@google.com>
Signed-off-by: Yarong Mu <ymu@google.com>
|
@khluu Please review. Thanks! |
NickLucche
left a comment
NickLucche
left a comment
There was a problem hiding this comment.
Very much needed!
On the other hand it would be nice to move all this logic at the buildkite level or any "steps" system that would help cleaning out the repetitive bits here.
…ject#17334) Signed-off-by: Yarong Mu <ymu@google.com> Signed-off-by: 汪志鹏 <wangzhipeng628@gmail.com>
…ject#17334) Signed-off-by: Yarong Mu <ymu@google.com> Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
…ject#17334) Signed-off-by: Yarong Mu <ymu@google.com>
…ject#17334) Signed-off-by: Yarong Mu <ymu@google.com> Signed-off-by: Yuqi Zhang <yuqizhang@google.com>
|
|
4 participants
Currently if one test fails, all subsequent ones do not run.