Skip to content

implement Structural Tag with Guidance backend #17333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 29, 2025
Merged

implement Structural Tag with Guidance backend #17333

merged 1 commit into from
Apr 29, 2025

Conversation

@mmoskal
Copy link
Contributor

@mmoskal mmoskal commented Apr 28, 2025 •
edited by github-actions bot
Loading

This implements #17085 for Guidance backend.

cc @mgoin @russellb

@mmoskal mmoskal requested review from mgoin and russellb as code owners April 28, 2025 23:40
@github-actions
Copy link

github-actions bot commented Apr 28, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

russellb
russellb approved these changes Apr 29, 2025
View reviewed changes
Copy link
Member

@russellb russellb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@russellb russellb enabled auto-merge (squash) April 29, 2025 00:37
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Apr 29, 2025
mgoin
mgoin approved these changes Apr 29, 2025
View reviewed changes
Copy link
Member

@mgoin mgoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto, great work. LGTM if green

@russellb russellb merged commit 86d9fc2 into vllm-project:main Apr 29, 2025
61 checks passed
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
@mmoskal @lk-chen
implement Structural Tag with Guidance backend (vllm-project#17333)
16c4427 
Signed-off-by: Michal Moskal <[email protected]>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@mmoskal
implement Structural Tag with Guidance backend (vllm-project#17333)
8d5dc08 
Signed-off-by: Michal Moskal <[email protected]>
Signed-off-by: Mu Huai <[email protected]>
zzzyq pushed a commit to zzzyq/vllm that referenced this pull request May 24, 2025
@mmoskal
implement Structural Tag with Guidance backend (vllm-project#17333)
f786a0b 
Signed-off-by: Michal Moskal <[email protected]>
Signed-off-by: Yuqi Zhang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@russellb russellb russellb approved these changes

@mgoin mgoin mgoin approved these changes

Assignees

No one assigned

Labels

ready ONLY add when PR is ready to merge/full CI is needed structured-output v1

Projects

Structured Output
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mmoskal @russellb @mgoin