[Bugfix] Fix numel() downcast in fused_layernorm_dynamic_per_token_quant.cu#17316
[Bugfix] Fix numel() downcast in fused_layernorm_dynamic_per_token_quant.cu#17316vllm-bot merged 1 commit intovllm-project:mainfrom
numel() downcast in fused_layernorm_dynamic_per_token_quant.cu#17316Conversation
…layernorm_dynamic_per_token_quant.cu +1 Summary: `numel()` has type `int64_t`. The implicit downcasts fix in this change artificially truncate data ranges which can lead to hard-to-debug errors and SEVs. Using `auto` ensures that the correct data type is used. Reviewed By: dtolnay Differential Revision: D73608869
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
|
This pull request was exported from Phabricator. Differential Revision: D73608869 |
|
LGTM, thank you! |
tlrmchlsmth
changed the title
numel() downcast in vllm/csrc/quantization/fused_kernels/fused_layernorm_dynamic_per_token_quant.cu +1numel() downcast in fused_layernorm_dynamic_per_token_quant.cu
…quant.cu (vllm-project#17316) Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
…quant.cu (vllm-project#17316) Signed-off-by: Yuqi Zhang <yuqizhang@google.com>
4 participants
Summary:
numel()has typeint64_t. The implicit downcasts fix in this change artificially truncate data ranges which can lead to hard-to-debug errors and SEVs. Usingautoensures that the correct data type is used.Reviewed By: dtolnay
Differential Revision: D73608869